From 5893bc57b8f027ad96a916b93a75143460c94b60 Mon Sep 17 00:00:00 2001
From: tamsin johnson <tomjohnson@ucsb.edu>
Date: Wed, 30 Aug 2023 17:29:04 -0700
Subject: [PATCH] don't force "Collection" model filter from the view

the search builders for the target controller already search effectively for the
model class, and may have better strategies for doing so in the future. adding a
filter here prevents applications from using Collection models not named
"Collection".
---
 app/views/hyrax/admin/collection_types/index.html.erb | 2 +-
 spec/factories/hyrax_collection.rb                    | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/app/views/hyrax/admin/collection_types/index.html.erb b/app/views/hyrax/admin/collection_types/index.html.erb
index 63c1a2358f..94481e2417 100644
--- a/app/views/hyrax/admin/collection_types/index.html.erb
+++ b/app/views/hyrax/admin/collection_types/index.html.erb
@@ -40,7 +40,7 @@
                  <% unless collection_type.admin_set? || collection_type.user_collection? %>
                   <button class="btn btn-danger btn-sm delete-collection-type"
                           data-collection-type="<%= collection_type.to_json %>"
-                          data-collection-type-index="<%= hyrax.dashboard_collections_path({ 'f[collection_type_gid_ssim][]' => collection_type.to_global_id.to_s, 'f[has_model_ssim][]' => 'Collection' }) %>"
+                          data-collection-type-index="<%= hyrax.dashboard_collections_path({ 'f[collection_type_gid_ssim][]' => collection_type.to_global_id.to_s }) %>"
                           data-has-collections="<%= collection_type.collections.any? %>">
                     <%= t('helpers.action.delete') %>
                   </button>
diff --git a/spec/factories/hyrax_collection.rb b/spec/factories/hyrax_collection.rb
index 775289a0e0..77d5d6d390 100644
--- a/spec/factories/hyrax_collection.rb
+++ b/spec/factories/hyrax_collection.rb
@@ -26,7 +26,7 @@
     after(:create) do |collection, evaluator|
       if evaluator.members.present?
         evaluator.members.map do |member|
-          member.membner_of_collection_ids += [collection.id]
+          member.member_of_collection_ids += [collection.id]
           member = Hyrax.persister.save(resource: member)
           Hyrax.index_adapter.save(resource: member) if evaluator.with_index
         end