Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bookmark_control partials create junk User entries #6986

Open
1 task
aploshay opened this issue Dec 12, 2024 · 0 comments
Open
1 task

bookmark_control partials create junk User entries #6986

aploshay opened this issue Dec 12, 2024 · 0 comments

Comments

@aploshay
Copy link
Contributor

Descriptive summary

Rendering either of these partials:
app/views/hyrax/dashboard/collections/_bookmark_control.html.erb
app/views/hyrax/collections/_bookmark_control.html.erb
calls current_or_guest_user which runs through blacklight and then through devise-guests, where it will create a guest user account if there's no current user.

This is a consistent issue with bookmarks behavior in blacklight, where we probably don't want to create a persistent guest account that can then never be re-used later...

For these 2 partial, suggest replacing current_or_guest_user calls with current_user

Steps to reproduce the behavior in User Interface (UI)

  1. In console, check the current User.count
  2. While not logged in to the hyrax app, visit a page that renders either bookmark_control partial
  3. Re-check User.count in console, note that there's a new guest user, with a created_at timestamp when step 2 happened

Actual behavior (include screenshots if available)

Creates a new user account, if there's no current_user logged in.

Acceptance Criteria/Expected Behavior

  • rendering either partial does not result in a new, persistent, guest user account getting created
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant