You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is a consistent issue with bookmarks behavior in blacklight, where we probably don't want to create a persistent guest account that can then never be re-used later...
For these 2 partial, suggest replacing current_or_guest_user calls with current_user
Steps to reproduce the behavior in User Interface (UI)
In console, check the current User.count
While not logged in to the hyrax app, visit a page that renders either bookmark_control partial
Re-check User.count in console, note that there's a new guest user, with a created_at timestamp when step 2 happened
Actual behavior (include screenshots if available)
Creates a new user account, if there's no current_user logged in.
Acceptance Criteria/Expected Behavior
rendering either partial does not result in a new, persistent, guest user account getting created
The text was updated successfully, but these errors were encountered:
Descriptive summary
Rendering either of these partials:
app/views/hyrax/dashboard/collections/_bookmark_control.html.erb
app/views/hyrax/collections/_bookmark_control.html.erb
calls
current_or_guest_user
which runs throughblacklight
and then throughdevise-guests
, where it will create a guest user account if there's no current user.This is a consistent issue with bookmarks behavior in blacklight, where we probably don't want to create a persistent guest account that can then never be re-used later...
For these 2 partial, suggest replacing
current_or_guest_user
calls withcurrent_user
Steps to reproduce the behavior in User Interface (UI)
User.count
User.count
in console, note that there's a new guest user, with acreated_at
timestamp when step 2 happenedActual behavior (include screenshots if available)
Creates a new user account, if there's no
current_user
logged in.Acceptance Criteria/Expected Behavior
The text was updated successfully, but these errors were encountered: