Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggesting Rewrite to how Datasets are Populated #163

Open
mraguso2 opened this issue Oct 25, 2021 · 3 comments
Open

Suggesting Rewrite to how Datasets are Populated #163

mraguso2 opened this issue Oct 25, 2021 · 3 comments

Comments

@mraguso2
Copy link

I think it may be easier to maintain if there was one large DatasetDictionary js object that included information for every dataset {name, id, download, classification, pathname} and then were looped and populated into html elements.

Something like:
Snit-it

I saw that you have some outstanding PR's that update the UI so there could be some conflicts with a change this big but it would greatly clean up you index.html file and allow for easier dataset edits

Let me know what you think - I already started the work on this if you are interested in moving to this functionality.

@samz5320
Copy link
Owner

i wanted to keep it simple ,for people contributing for the first time also. they could drop in a dataset by copying above code and changing id in few lines.

@mraguso2
Copy link
Author

I think this suggested workflow to add datasets would be pretty simple.

All the person would need to do is:

  • add the raw dataset
  • make a new dataset item in the dataset object with all those standard keys {name, id, pathname, etc}.

This allows you to easily make edits to the html structure if you ever needed to, since it is simply looping over this dataset and plugging in values for each dataset.

I can send over the PR soon to show you how it could work and if you're not interested I can close this issue

@samz5320
Copy link
Owner

yup send a PR. tq

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants