-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaced copy button to icon #61
Conversation
✔️ Deploy Preview for zen-visvesvaraya-18f5e7 ready! 🔨 Explore the source changes: afdf24e 🔍 Inspect the deploy log: https://app.netlify.com/sites/zen-visvesvaraya-18f5e7/deploys/615b3e81c81cca0007fdd7cf 😎 Browse the preview: https://deploy-preview-61--zen-visvesvaraya-18f5e7.netlify.app/ |
Please accept the Pull Request, so that I can create new pull requests. |
can u try the download icon as it is? also try some colors for the copy link icon pls. |
Ok sure I'll do that. |
It will take some time to accept ur pr cause there are a lot of UI and functional changes suggested by contributors. |
I have added a downloaded copy.svg file for copy icon ( which was using font-awesome cdjns before) and also have changed the color-theme of icons to make the theme of both download and copy icons same.Below are the two screenshot of dark theme and light theme. Light ThemeDark themeAlso, Please let me know that would I have to create a new pull request or you are able to fetch my commits through this one.And the last point is that you can tell me the colors to use on buttons if you feel that will look better ( Although we can do that easily even at a later step) |
I can merge this Pr only. there is a lot of blue XD. |
It is showing me that all commits will be automatically merged. |
@samz5320 This PR was showing 3 file conflicts found, actually the fact is that after adding each dataset in the website one conflict will be created each time as the contributors working on this repository are still using the old copy button HTML. This time I have solved all the conflicts manually and there is No conflict right now so In my opinion you should merge this PR before you go for the PR's for adding datasets. |
The problem is others are working on making "Copy" to "Copied" . and you have added an SVG icon. |
@samz5320 Ohh got it!actually what I was thinking is that to make this like that one icon that GitHub uses (Image Attached).Actually if you think that merging this PR is not possible then kindly let me know I will close this PR and will work on other issues in your repo. 😄 |
Meanwhile one more conflict encountered 😅 |
Let me know that should I keep removing the conflicts or close this PR |
Yup close this PR. pls u can push once u decide on the design |
Replaced the copy button with the icon
Also added transition to both download and a copy button.
Fixes #51
Explain the Testing instructions
Test Configuration:
* Operating system: windows 11(insider preview)
* Build: 22000.194
* Text-editors used: VS Code