Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced copy button to icon #61

Closed
wants to merge 3 commits into from
Closed

Replaced copy button to icon #61

wants to merge 3 commits into from

Conversation

amitmaindola
Copy link
Contributor

Replaced the copy button with the icon

Also added transition to both download and a copy button.

Fixes #51

dark-mode-1
light-mode-1

Explain the Testing instructions

Test Configuration:

* Operating system: windows 11(insider preview)

* Build: 22000.194

* Text-editors used: VS Code

@netlify
Copy link

netlify bot commented Oct 2, 2021

✔️ Deploy Preview for zen-visvesvaraya-18f5e7 ready!

🔨 Explore the source changes: afdf24e

🔍 Inspect the deploy log: https://app.netlify.com/sites/zen-visvesvaraya-18f5e7/deploys/615b3e81c81cca0007fdd7cf

😎 Browse the preview: https://deploy-preview-61--zen-visvesvaraya-18f5e7.netlify.app/

@amitmaindola
Copy link
Contributor Author

Please accept the Pull Request, so that I can create new pull requests.

@samz5320
Copy link
Owner

samz5320 commented Oct 3, 2021

can u try the download icon as it is? also try some colors for the copy link icon pls.

@amitmaindola
Copy link
Contributor Author

Ok sure I'll do that.

@samz5320
Copy link
Owner

samz5320 commented Oct 3, 2021

It will take some time to accept ur pr cause there are a lot of UI and functional changes suggested by contributors.
I will have to review and test each change.

@samz5320 samz5320 added the major PR might bring on major/more changes to base. label Oct 3, 2021
@amitmaindola
Copy link
Contributor Author

I have added a downloaded copy.svg file for copy icon ( which was using font-awesome cdjns before) and also have changed the color-theme of icons to make the theme of both download and copy icons same.

Below are the two screenshot of dark theme and light theme.
NOTE : On hover the color theme of buttons become as other one before having

Light Theme

light-mode-2

Dark theme

dark-mode-2

Also, Please let me know that would I have to create a new pull request or you are able to fetch my commits through this one.

And the last point is that you can tell me the colors to use on buttons if you feel that will look better ( Although we can do that easily even at a later step)

@samz5320
Copy link
Owner

samz5320 commented Oct 3, 2021

I can merge this Pr only. there is a lot of blue XD.

@amitmaindola
Copy link
Contributor Author

It is showing me that all commits will be automatically merged.

@amitmaindola
Copy link
Contributor Author

@samz5320 This PR was showing 3 file conflicts found, actually the fact is that after adding each dataset in the website one conflict will be created each time as the contributors working on this repository are still using the old copy button HTML.
And It will be more and more difficult to solve the conflicts as more and more datasets are introduced.

This time I have solved all the conflicts manually and there is No conflict right now so In my opinion you should merge this PR before you go for the PR's for adding datasets.

@samz5320
Copy link
Owner

samz5320 commented Oct 4, 2021

The problem is others are working on making "Copy" to "Copied" . and you have added an SVG icon.

@amitmaindola
Copy link
Contributor Author

@samz5320 Ohh got it!

actually what I was thinking is that to make this like that one icon that GitHub uses (Image Attached).

image

Actually if you think that merging this PR is not possible then kindly let me know I will close this PR and will work on other issues in your repo. 😄

@amitmaindola
Copy link
Contributor Author

Meanwhile one more conflict encountered 😅

@amitmaindola
Copy link
Contributor Author

Let me know that should I keep removing the conflicts or close this PR

@samz5320
Copy link
Owner

samz5320 commented Oct 5, 2021

Yup close this PR. pls u can push once u decide on the design

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major PR might bring on major/more changes to base.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copy icon instead of the button
2 participants