Skip to content

Commit 6780177

Browse files
Fenix-125sanderhollaar
authored andcommitted
media: i2c: arducam-pivariety: Fix mutex init and NULL pointer
The mutex used in arducam-pivariety was not properly initialized, which could lead to undefined behavior. This also caused a NULL pointer dereference under certain conditions. This patch ensures the mutex is correctly initialized during probe and prevents NULL pointer dereferences. Signed-off-by: Yuriy Pasichnyk <yurijpasichnyk11@gmail.com>
1 parent c76a485 commit 6780177

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

drivers/media/i2c/arducam-pivariety.c

+3
Original file line numberDiff line numberDiff line change
@@ -1208,6 +1208,8 @@ static int pivariety_enum_controls(struct pivariety *pivariety)
12081208
if (ret)
12091209
return ret;
12101210

1211+
mutex_init(&pivariety->mutex);
1212+
12111213
index = 0;
12121214
while (1) {
12131215
ret = pivariety_write(pivariety, CTRL_INDEX_REG, index);
@@ -1295,6 +1297,7 @@ static int pivariety_enum_controls(struct pivariety *pivariety)
12951297
v4l2_ctrl_handler_setup(ctrl_hdlr);
12961298
return 0;
12971299
err:
1300+
mutex_destroy(&pivariety->mutex);
12981301
return -ENODEV;
12991302
}
13001303

0 commit comments

Comments
 (0)