Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some bugs need to fix #1

Open
wangx404 opened this issue Mar 2, 2018 · 1 comment
Open

some bugs need to fix #1

wangx404 opened this issue Mar 2, 2018 · 1 comment

Comments

@wangx404
Copy link

wangx404 commented Mar 2, 2018

There are some bugs in the script.
such as in Class Data_Loader, with open(os.path.join(path,"train.pickle"),"r") as f: would raise an error. As the pickle file was save in byte mode, but in this line, it was opened in str mode. So the 'r' should be replaced by 'rb'.
In other parts, there are some other bugs. Please fix it if you have time. 3Q.
P.S. I don't yet know how to pull a request, sorry for that.

@sandonair007
Copy link
Owner

Sorry for the late reply. I've rerun the code but cannot reproduce the error you mentioned. I think it is due to the python version. In python 2.7, it should be fine. But I have to admit that it is better to use "rb" when reading the pickle file as you pointed out.

Please let me know any other issues you found. Thank you again for your time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants