Skip to content

Commit 2e4ed3a

Browse files
cansarigolahopkins
andauthored
Replaced default list server variables with object (#220)
Co-authored-by: Adam Hopkins <adam@amhopkins.com>
1 parent 4b7af45 commit 2e4ed3a

File tree

2 files changed

+10
-1
lines changed

2 files changed

+10
-1
lines changed

sanic_ext/extensions/openapi/definitions.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -352,7 +352,7 @@ def __init__(
352352
variables: Optional[Dict[str, Any]] = None,
353353
):
354354
super().__init__(
355-
url=url, description=description, variables=variables or []
355+
url=url, description=description, variables=variables or {}
356356
)
357357

358358

tests/extensions/openapi/test_definitions.py

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
import pytest
44

5+
from sanic_ext.extensions.openapi.definitions import Server
56
from sanic_ext.extensions.openapi.types import Definition
67

78

@@ -45,3 +46,11 @@ def test_serialize_no_nullable(Thing):
4546
assert serialized["name"] == "ok"
4647
assert "foo" not in serialized
4748
assert "bar" not in serialized
49+
50+
51+
def test_server_definitions_defaults():
52+
assert Server(url="url").fields == {
53+
"url": "url",
54+
"description": None,
55+
"variables": {},
56+
}

0 commit comments

Comments
 (0)