Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no member named w in the linear_regression structure #4

Open
wyoung1 opened this issue Apr 16, 2024 · 0 comments
Open

no member named w in the linear_regression structure #4

wyoung1 opened this issue Apr 16, 2024 · 0 comments

Comments

@wyoung1
Copy link

wyoung1 commented Apr 16, 2024

Dear İbrahim Ümit Akgün,

I'm sorry to bother you. I am writing to bring to your attention a bug that I encountered while reviewing the code in mq-adios.c in the kernel-ml-linux repository.

Upon inspecting the code at line 495 of mq-adios.c, I noticed the following snippet:

io_sched_linear = build_linear_regression(0.03, 10, 0.99, 2);
io_sched_linear->check_correctness = io_scheduler_linear_check_correction;
set_random_matrix(io_sched_linear->w, modula);
The variable io_sched_linear is of type struct linear_regression, as defined in linear_regression.h. However, it appears that there is no member named w in the linear_regression structure. This inconsistency has resulted in compilation errors.

Here is the relevant definition of the linear_regression structure:

typedef struct linear_regression {
int batch_size;
sgd_optimizer *sgd;
loss *loss;
layers *layer_list;
bool (*check_correctness)(val result, val prediction);

model_data data;
model_multithreading multithreading;
model_state state;
} linear_regression;
Could you please look into this issue and provide a fix? It seems that there may be a discrepancy between the code in mq-adios.c and the definition of the linear_regression structure.

Thank you for your attention. I appreciate your efforts in maintaining the kernel-ml-linux repository.

Best regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant