FR: Cropping

[Skeletorjus]

Since the map often includes lots of empty space it would be useful to be able to crop the image. This could either be done by specifying pixels to crop from top/bottom/left/right or by drawing a square with a cursor akin to a zone-creator.

The output can be cropped in xiaomi-vacuum-map-card, but that won't affect the generated snapshots or any other visualization of the map.

[sca075]

The Valetudo maps are normally size wise are (5120 x 5120 or even bigger) huge the camera image can be actually crop on the options (default is 50% but you can use less for example 25% to reduce it).

I would add a image trim function on the camera (same as the one the card actually offer) to select top, bottom, left or right space to be "cut out" from the resulting image.. this would help to centre the image without using the cropping or trimming function on the card and also keep the snapshots same as the output on the card.

[sca075]

F.Y.I. trim function implemented and tested on the test code I use for troubleshooting, will be available next Friday on the new version of this integration hopefully, I still need to work out the new config_flow, where the new parameters can be set. I actually thought to add also a text on the top right conner of the image that will output the vacuum status (this will be also included as an option) so that when the camera take the snapshot the status of the vacuum will be display also on the image. I count to close also the story of the room configuration on the new version but no promises here. Additionally from our discussions it comes out I think a great idea.. would be really cool if Gen1 vacuums get the zones predefined (same principle of the rooms, I think this should be possible by following the walls). This last two actually needs a little of lines to add :) but in the end I guess can make the real difference.

[sca075]

@Skeletorjus hope everything works fine with your vacuums, I just released the v1.3.2 that support the images trimming. Thanks a lots for your inputs much appreciated 🥇

[sca075]

@Skeletorjus let me say.. you are a really valuable user here.. I found the problem.. you are right the values change with the rotation of the image. This will be fixed soon ;) thanks a lot.. (N.B. Im opening an issue to keep track of it)

[Skeletorjus]

Thank a lot! Glad you found the issue. I use a rotation of zero.

[sca075]

@Skeletorjus the function is fixed and v1.3.3 is released.. I hope this can help and hat you can enjoy it :)

[Skeletorjus]

Working great! Thanks!

[sca075]

@Skeletorjus Thank to you for the really good advice:) happy that it did work 😃
I'm closing this discussion at this point, also because it is everything documented on the docs.
Thank you once again ;)