Only one room available when configuring room colors

[kevinduong]

Checklist

• I have updated the integration to the latest version available
• I have checked if the problem is already reported

The problem

When changing room colors, only one option shows up for one room. The integration is reporting multiple segements (7). When adjusting this color, it didn't modify the floor color which I would have expected if there was an issue with segments/rooms. It correctly updated the color of the one room.

What version of an integration has described problem?

2024.6.0

What was the last working version of an integration?

No response

What vacuum model do you have problems with?

Roborock S5 Valetudo

Please firmware installed on your Vacuum.

2024.02.0

What type of platform you use?

VEMLinux (Virtual Machine) such as Proxmox, VMWare, etc.

What version of Home Assistant do you use?

core-2024.5.5

What type of installation are you running?

Home Assistant OS

Camera's settings.

No response

Logs or Errors shown in the HA snapshots (please enable the Debug Mode)

No response

Additional information

No response

[sca075]

@kevinduong is there any errors in the logs of HA?
I used an S5 too to check it pre-release. It is possible that the rooms data was not available. Can you please share the logs?

[kevinduong]

I'm not seeing anything in my HA logs that could relate to this. Something I did notice is that I don't have a .json that this line is looking for https://github.com/sca075/valetudo_vacuum_camera/pull/157/files#diff-7a92566dc654210611343ea0ef0fdceb787bc6d3351ad69afdf9704c89326774R27

[sca075]

That file should come with the rooms colours rename functions.. this is why probably I didn't get it in tests I've done.. sorry for that, I will fix it as soon. Thanks a lot @kevinduong.

[kevinduong]

No worries. Glad I could help out in some way. Thanks for spending the time to look into it.

[jgkawell]

Just for the record I'm having the same issue with my (new) installation.

[sca075]

@jgkawell (new) installation = Home Assistant new setup -> then Camera and Card or vice versa. is that correct? I would like to get it right and fix this once per all thanks a lot for your feedback @jgkawell. As you later commented that could be possible to roll back to the previous version of the camera I assumed that was just the Camera update that caused the issue... I thought long ago to provide the possibility to export the camera settings and give to the users the possibility to re-import those settings to facilitate the setup this custom component.. that is quite a work to do but I think cool to have (as per for example myself several instances of HA for testing).. this isn't of course happening soon but I would implement it later on.
Thanks once again for the feedback and eventually cooperation ;) if not a star for this project that would mean quite a lot as you can imagine 😄

[jgkawell]

It was an existing HA install but got a new vacuum so I had installed the camera and card for the first time.

It would be cool to export settings but honestly not necessary :)

[sca075]

Well currently we have a bigger problem to solve.. #161 but I promise I will do my best to fix this, as per there will be to reinstall the camera probably with the fix of #161. It feels really sad honestly... I found anyhow a lot of small imperfections and 2024.06.0 was released too early.. I had no time to fully test it. I admit the next will be not that better but I will do my best to keep it working.. as per it was designed.

[jgkawell]

No worries, thanks for building this and trying to fix things! :) Until fixes come out could I just roll back to the last version? I'm assuming that won't break anything.

[sca075]

Did release the 2024.06.1 hopefully this issue will be closed too by then. The release is locked as requires HA 2024.6.0.
You can although test it if you want, downloading the main, please note that common.py currently in use on the camera 2024.06.0 or earlier is the one you should keep when you want to test it. I could prepare a test release if needed,
Please do not forget to start the project if you didn't yet.

[sca075]

@kevinduong and @jgkawell I suppose by now you are aware that unfortunately the issue with users_data.py is persisting, I got also a validation error for the calibration_data (one of the two vacuums I have is with battery empty and this is creating this error).

Will review the code again as soon I'm done at work.

[sca075]

@kevinduong just one question the problem with rooms colours was then solved?

[rj-d2]

im a new user, 5 days since rooting and flashing valetudo on my dreame L10s ultra, im just joining in to say i never was able to see more than 1 rooms when i try to change room colours, i was hoping 2024.06.2 would fix this but no luck so far.
thx for this great integration!

[sca075]

@rj-d2 will change the default value and in the the next 2024.06.3b2 we can test if this works for you guys.

[sca075]

The issue was closed automatically because of the pull request merged few minutes ago. I will move it to discussions, please test the 2024.06.3b2 that will be published soon.

[sca075]

2024.06.3b2 downloads are now possible with HACS (enabled beta).
Please let me know if this works and you can configure your rooms colors.

[sca075]

@rj-d2 did you have the possibility to try the 2024.06.3b2 ? would be really appreciated when you could confirm.
Just to better understand:

• The camera was installed for the first time so there was no camera data in the HA instance.
• You configured the vacuum and wait for the entity to be created.
• Then you configured the card I guess. Generate Rooms Configuration in the card did work correctly I guess.
• When you did try to change the rooms colours only one room was present.

Is my understanding correct?

I'm just trying to figure out how this happened. For background explanation of the default 1 room, I did it because in the case of V1 there are no rooms data and some older vacuum of course too, there is just one floor colour. Now for a fact there are Jsons in some vacuum as dreame that has floor then segments.. as we count only segments probably the query did not get the segments because those are under floor. @kevinduong is using an S5 that is the same vacuum I use for the tests and I guess it was because the rooms count is in a json that wasn't there as he rightly pointed out.

I guess on of all of you understating, it is a quite tuff period (life/work wise) but I'm just trying to get this project right and provide this "solution" not for money or fame (this isn't a product but just an utility), because I feel right to share this and make it available to everyone (therefore should work for every one). I like the challenges also if sometime are overwhelming, would although really appreciate your help/feedback guys, and of course I perfectly understand that "time".

I'm going to reconvert this to an issue as it was reported, as per I didn't get any feedback that this somehow worked for you.

[rj-d2]

i just tested it, 2024.06.3b2 works, i can change the room colours now. thx for your time and dedication

[jgkawell]

Same! It's working perfectly now. Thanks @sca075 !!

[sca075]

@kevinduong waiting for your kind feedback, would you let me know if we can close this issue with this new spec?

[kevinduong]

Tested on 2024.06.3b2 and it looks good to me now. Thanks for all of your hard work on this.

[sca075]

Thanks for confirming it :)

[EnUfor]

I still had this issue persist after updating to 2024.07.3 (2024.07.2 HA OS). I was seeing the errors about missing JSON like kevinduong was above in the logs:

Logger: custom_components.mqtt_vacuum_camera.utils.users_data
Source: custom_components/mqtt_vacuum_camera/utils/users_data.py:38
integration: MQTT Vacuum Camera
First occurred: 10:11:20 AM (32 occurrences)
Last logged: 10:31:20 AM
File not found: /config/.storage/valetudo_camera/room_data_l10pro.json
File not found: /config/.storage/valetudo_camera/room_data_robocks7.json

Between my Dreame L10 Pro and Roborock S7 (both latest Valetudo and dustbuilder firmware for each), I tried deleting the integration entities and recreate them, but the issue still persisted (must've done it too quick?). I tried again re-creating the entity (slower) and now rooms show (yay!), but there's a two issues I see now:

1. The UI is showing an incorrect key/pair for each ID/room-name
2. Rooms that aren't on that floor are showing
   • Bathroom and Bedroom are present, Nail Room and Kitchen are missing for Roborock S7
   • Room names are randomly populated for Dreame L10 Pro (from the other vacuum?)

Roborock S7:

Dreame L10 Pro:

I am wondering both issues are a result of room names not being assigned for the Dreame L10 Pro as I recently had to remap the floor. Please let me know if it makes sense to open a new issue for this.

[sca075]

@EnUfor Thanks I'm actually working on it and I think it could be (don't if this is the case).. pull #212 referenced to issue #209
About the rooms name you found in there I guess the translation file was miss-copied by me... Anyhow, I just published a beta, would you mind to confirm 2024.07.4b0, I think the actual issue is that the data should be stored as soon generated (it might be an issue with the asyinc mode), I would need more than other the startup log of the camera (the data are stored at the first snapshot). Also if you can share the states attributes of the camera, this could be really help-full to understand where the problem could be.

[sca075]

@EnUfor I found the problem with the rooms names, I think it will be corrected in the next days :)