Camera: reset trim -> Specs Redefine / Fix and improve

[Minims]

Hello,

In 2024.8.0, does this action

action: mqtt_vacuum_camera.reset_trims
data: {}
target:
  entity_id: camera.roger_camera

is supposed to be the same as
Integration > MQTT Vacuum Camera > Configure > Advanced options > Reset trims ?

My problems is that i have configure camera for Floor-0. All is OK. Then i load the Floor-1 Map. The map is cropped and not centered.

I run : Integration > MQTT Vacuum Camera > Configure > Advanced options > Reset trims.

And the floor-1 map is OK.

I would expect the actions does the same thing, but it's currently not the case.

might be related to #207
but don't want to hijack this discussion.

Thanks for the help.

[sca075]

@Minims
you are correct he action setup should be something like:

action: mqtt_vacuum_camera.reset_trims
target:
  entity_id: camera.roger_camera
data: {}

Reload Trims with this action will actually reset the trims and reload the camera at the same time. The point of this action is to be used when the vacuum actually rescan the floor. If the Floor - 1 isn't centered reset_trim might solve the image margining, unless if there are actually margins setup in the camera configuration.. that honestly if it is the case we might reset as well.

Are you using the maploader on Rand256? If yes I would give it a try.

When you use Integration > MQTT Vacuum Camera > Configure > Advanced options > Reset trims and then __reload __ the camera after the vacuum completed the scan or load a second map the image should be re-trim. Same as running the service.

As I'm still running Rand256, and I know it is possible to save multiple maps... can you please be more precise and let me know if you intend to use the same vacuum on both floors? This is actually interesting and I don't know if we can "automate this process" using the Camera code.

I will in any cases check (and change probably something on the reload "action") as per I noticed there could be some improvement, it looks that with more then one vacuum probably this action need to be target too.

Hope this help, anytime, please let me know if we can improve something here.

[Minims]

Are you using the maploader on Rand256? If yes I would give it a try.

No i am just using Valetudo RE 10.10. And i'm loading the map with this service.

  - icon: mdi:home-floor-0
    tooltip: Rez de Chaussée
    tap_action:
      action: call-service
      service: vacuum.send_command
      service_data:
        entity_id: vacuum.roger_roborock_s5
        command: load_map
        params:
          name: Rez de Chaussee
  - icon: mdi:reload
    tooltip: Reload
    tap_action:
      action: call-service
      service: mqtt_vacuum_camera.reload
  - icon: mdi:box-cutter
    tooltip: Trim
    tap_action:
      action: call-service
      service: mqtt_vacuum_camera.reset_trims
      target:
        entity_id: camera.roger_camera

When you use Integration > MQTT Vacuum Camera > Configure > Advanced options > Reset trims and then __reload __ the camera after the vacuum completed the scan or load a second map the image should be re-trim. Same as running the service.

This is working great.

But service/action call mqtt_vacuum_camera.reset_trims does nothing. Map is not re-trim.

let me know if you intend to use the same vacuum on both floors

Yes. I use my S5 on both floors. I have save my 2 maps.
On floor change; i 'm loading the map :

      action: call-service
      service: vacuum.send_command
      service_data:
        entity_id: vacuum.roger_roborock_s5
        command: load_map
        params:
          name: Rez de Chaussee

Trim

      service: mqtt_vacuum_camera.reset_trims
      target:
        entity_id: camera.roger_camera

Reload by security, but it seems trim already did it.

      service: mqtt_vacuum_camera.reload

[sca075]

Okay "ValetudoRe = Rand256 is the same", then I will check the reset_trims "Action" by the way.. would you please try this:

  - icon: mdi:home-floor-0
    tooltip: Rez de Chaussée
    tap_action:
      action: call-service
      service: vacuum.send_command
      service_data:
        entity_id: vacuum.roger_roborock_s5
        command: load_map
        params:
          name: Rez de Chaussee
  - icon: mdi:reload
    tooltip: Reload
    tap_action:
      action: call-service
      service: mqtt_vacuum_camera.reload
  - icon: mdi:box-cutter
    tooltip: Trim
    tap_action:
      action: call-service
      service: mqtt_vacuum_camera.reset_trims
      target:
        entity_id: camera.roger_camera
      data: {}

Adding the "data" = {} for the service, this config is in the card correct? I would check if I can reproduce this ;)

Additionally reload is not necessary when you un the reset_trims.

[Minims]

I have tried this

  - icon: mdi:box-cutter
    tooltip: Trim
    tap_action:
      action: call-service
      service: mqtt_vacuum_camera.reset_trims
      target:
        entity_id: camera.roger_camera
      data: {}

Reload is working, but trim does nothing.

FYI, doing the same thing in Developpement > Actions does not work too.

action: mqtt_vacuum_camera.reset_trims
data: {}
target:
  entity_id: camera.roger_camera

[sca075]

... also.. I think.. I will change the code so that if there is a trims_reset and the vacuum is "cleaning" then the file with the new trim data should be saved at the end of the cycle Cleaning -> Docked = Save trims at the last image.. "snapshot time", instead of immediately. This should refresh the images "centring" them correctly.

[sca075]

@Minims,

Probably there is an issue with the "Action" reset_trims this is what I found by re-testing it.

2024-08-09 11:11:31.203 DEBUG (MainThread) [custom_components.mqtt_vacuum_camera] Resetting trims for ['camera.vacuum_camera']
2024-08-09 11:11:31.204 DEBUG (MainThread) [custom_components.mqtt_vacuum_camera.utils.files_operations] Resetting the map trims.
2024-08-09 11:11:31.211 DEBUG (MainThread) [custom_components.mqtt_vacuum_camera.utils.files_operations] File not found: /config/.storage/valetudo_camera/auto_crop_vacuum.json
2024-08-09 11:14:39.491 DEBUG (MainThread) [custom_components.mqtt_vacuum_camera.config_flow] Options edit in progress.. options before edit: {'rotate_image': '180', 'margins': '200', 'aspect_ratio': '16, 9', 'offset_top': 200, 'offset_bottom': 200, 'offset_left': 100, 'offset_right': 150, 'auto_zoom': True, 'zoom_lock_ratio': True, 'show_vac_status': True, 'vac_status_size': 50.0, 'vac_status_position': True, 'vac_status_font': 'custom_components/mqtt_vacuum_camera/utils/fonts/FiraSans.ttf', 'get_svg_file': False, 'enable_www_snapshots': False, 'color_charger': [255, 128, 0], 'color_move': [238, 247, 255], 'color_wall': [255, 255, 0], 'color_robot': [255, 255, 204], 'color_go_to': [0, 255, 0], 'color_no_go': [255, 0, 0], 'color_zone_clean': [255, 255, 255], 'color_background': [0, 125, 255], 'color_text': [182, 22, 22], 'alpha_charger': 255.0, 'alpha_move': 255.0, 'alpha_wall': 255.0, 'alpha_robot': 255.0, 'alpha_go_to': 255.0, 'alpha_no_go': 125.0, 'alpha_zone_clean': 125.0, 'alpha_background': 255.0, 'alpha_text': 255.0, 'color_room_0': [135, 206, 250], 'color_room_1': [176, 226, 255], 'color_room_2': [165, 105, 18], 'color_room_3': [164, 211, 238], 'color_room_4': [141, 182, 205], 'color_room_5': [96, 123, 139], 'color_room_6': [224, 255, 255], 'color_room_7': [209, 238, 238], 'color_room_8': [180, 205, 205], 'color_room_9': [122, 139, 139], 'color_room_10': [175, 238, 238], 'color_room_11': [84, 153, 199], 'color_room_12': [133, 193, 233], 'color_room_13': [245, 176, 65], 'color_room_14': [82, 190, 128], 'color_room_15': [72, 201, 176], 'alpha_room_0': 255.0, 'alpha_room_1': 255.0, 'alpha_room_2': 255.0, 'alpha_room_3': 255.0, 'alpha_room_4': 255.0, 'alpha_room_5': 255.0, 'alpha_room_6': 255.0, 'alpha_room_7': 255.0, 'alpha_room_8': 255.0, 'alpha_room_9': 255.0, 'alpha_room_10': 255.0, 'alpha_room_11': 255.0, 'alpha_room_12': 255.0, 'alpha_room_13': 255.0, 'alpha_room_14': 255.0, 'alpha_room_15': 255.0}
2024-08-09 11:14:39.514 INFO (MainThread) [custom_components.mqtt_vacuum_camera.config_flow] rockrobo_camera: Options Configuration Started.
2024-08-09 11:14:42.702 INFO (MainThread) [custom_components.mqtt_vacuum_camera.config_flow] rockrobo_camera: Options Configuration Started.
2024-08-09 11:14:47.110 DEBUG (MainThread) [custom_components.mqtt_vacuum_camera.config_flow] Resetting the map trims.
2024-08-09 11:14:47.112 INFO (MainThread) [custom_components.mqtt_vacuum_camera.utils.files_operations] Removing the file /config/.storage/valetudo_camera/auto_crop_rockrobo.json
2024-08-09 11:14:47.113 INFO (MainThread) [custom_components.mqtt_vacuum_camera.config_flow] Storing Updated Camera (rockrobo_camera) Options.
2024-08-09 11:14:47.114 DEBUG (MainThread) [custom_components.mqtt_vacuum_camera.config_flow] updated options:{'rotate_image': '180', 'margins': '200', 'aspect_ratio': '16, 9', 'offset_top': 200, 'offset_bottom': 200, 'offset_left': 100, 'offset_right': 150, 'auto_zoom': True, 'zoom_lock_ratio': True, 'show_vac_status': True, 'vac_status_size': 50.0, 'vac_status_position': True, 'vac_status_font': 'custom_components/mqtt_vacuum_camera/utils/fonts/FiraSans.ttf', 'get_svg_file': False, 'enable_www_snapshots': False, 'color_charger': [255, 128, 0], 'color_move': [238, 247, 255], 'color_wall': [255, 255, 0], 'color_robot': [255, 255, 204], 'color_go_to': [0, 255, 0], 'color_no_go': [255, 0, 0], 'color_zone_clean': [255, 255, 255], 'color_background': [0, 125, 255], 'color_text': [182, 22, 22], 'alpha_charger': 255.0, 'alpha_move': 255.0, 'alpha_wall': 255.0, 'alpha_robot': 255.0, 'alpha_go_to': 255.0, 'alpha_no_go': 125.0, 'alpha_zone_clean': 125.0, 'alpha_background': 255.0, 'alpha_text': 255.0, 'color_room_0': [135, 206, 250], 'color_room_1': [176, 226, 255], 'color_room_2': [165, 105, 18], 'color_room_3': [164, 211, 238], 'color_room_4': [141, 182, 205], 'color_room_5': [96, 123, 139], 'color_room_6': [224, 255, 255], 'color_room_7': [209, 238, 238], 'color_room_8': [180, 205, 205], 'color_room_9': [122, 139, 139], 'color_room_10': [175, 238, 238], 'color_room_11': [84, 153, 199], 'color_room_12': [133, 193, 233], 'color_room_13': [245, 176, 65], 'color_room_14': [82, 190, 128], 'color_room_15': [72, 201, 176], 'alpha_room_0': 255.0, 'alpha_room_1': 255.0, 'alpha_room_2': 255.0, 'alpha_room_3': 255.0, 'alpha_room_4': 255.0, 'alpha_room_5': 255.0, 'alpha_room_6': 255.0, 'alpha_room_7': 255.0, 'alpha_room_8': 255.0, 'alpha_room_9': 255.0, 'alpha_room_10': 255.0, 'alpha_room_11': 255.0, 'alpha_room_12': 255.0, 'alpha_room_13': 255.0, 'alpha_room_14': 255.0, 'alpha_room_15': 255.0}

the problem could be in the entity_id of the camera:
"File not found: /config/.storage/valetudo_camera/auto_crop_vacuum.json"
The service use the entity_id of the camera "vacuum", while the "Reset Trim" function in the configuration use the file_name "auto_crop_rockrobo.json" were rockrobo is the correct name in the file.

can you please rename the Camera entity_id as per the robot name? in your case:

camera.roger_camera

this should be equal to the name on the topic "vacuum_topic: valetudo/rockrobo" that by the way can be change in the vacuum configuration. So if your topic is "vacuum_topic: valetudo/roger" then definitely I need to probably open an issue here.

[Minims]

Ok so :

auto_crop_roborock-s5.json

rename from camera.roger_camera to camera.roborock-s5
- not allowed. I might need to update my topic with _ instead

[Minims]

So,

• I have update my identifer on valetudo from roborock-s5 to roborock_s5.
• I have del/add the camera integration.
• i have rename the camera entity from camera.roger_camera to camera.roborock_s5

And now all is working !! Thanks a lot 👍

[sca075]

In your case this can work, as the Rand256 is not having a "fake" camera as the original valetudo.
Just for the others and docs "camera.roborock_s5_camera" should be the entity_id of the camera, the "camera" at the end is to avoid that somehow we create a duplicated entity using Valetudo Original stream.

@Minims I'm happy that this worked as temporally. I will release the 2024.08.1 with a fix for this :)
P.s. If you didn't yet and don't mind.. please start the project this means really a lot to me.. thanks once again for your help on making this project growing better :)

[sca075]

The "Action" reload camera will now reload all "mqtt_vacuum_camera" at once, and the "reset_trim" do not need the data anymore as will delete all auto_crop_*.json so that also if the camera name is different from the robot name the file will be deleted. I also implemented a delay to write again the file, the file will be written when the vacuum is docked, so.. if the vacuum is scanning a new map there is no trim locked, the image should (from what tested) be refresh correctly. I noticed from the test that the path and robot are draw but there is some minor adjustment on the segments to do as they do not draw during the re-scan (tested with the standard valetudo on my V1).

From 2024.08.1 the Action "reset_trim" need to be format as following:

action: mqtt_vacuum_camera.reset_trims
data: {}

No more need to give the target.