Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When -Ybest-effort is used, do not spawn .betasty in successful compilations #21833

Open
jchyb opened this issue Oct 23, 2024 · 0 comments
Open
Labels
area:best-effort-compilation Anything concerning `.betasty`, `-Ybest-effort` and `-Ywith-best-effort-tasty` itype:enhancement

Comments

@jchyb
Copy link
Contributor

jchyb commented Oct 23, 2024

Compiler version

3.5.0+

Expectation

When -Ybest-effort is used, the compiler will always produce .betasty when in the pickler phase, regardless of whether the compilation up to this point had errors or not. This was so that even when the compiler fails later in the transform phases, we still have the betasty to rely on. However, this does not really make sense when considered from the build tool perspective, where in the situation where the compilation succeeds, it ends up having to clean up the files, with time wasted both on writing and subsequent deleting of the files.
We should have a separate phase for writing betasty, run directly after pickler or the first error in transform phases.

@jchyb jchyb added itype:enhancement area:best-effort-compilation Anything concerning `.betasty`, `-Ybest-effort` and `-Ywith-best-effort-tasty` labels Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:best-effort-compilation Anything concerning `.betasty`, `-Ybest-effort` and `-Ywith-best-effort-tasty` itype:enhancement
Projects
None yet
Development

No branches or pull requests

1 participant