From ca417e087568f51873f091bf769701e97a33aed2 Mon Sep 17 00:00:00 2001
From: Max Skanvik <179694889+max-umain@users.noreply.github.com>
Date: Tue, 17 Dec 2024 09:55:41 +0100
Subject: [PATCH] test(spinner): refactor tests to use beforeEach for page
 navigation

---
 .../spinner/test/inverted/darkmode/spinner.e2e.ts           | 4 +++-
 .../spinner/test/inverted/lightmode/spinner.e2e.ts          | 4 +++-
 .../spinner/test/standard/darkmode/spinner.e2e.ts           | 4 +++-
 .../spinner/test/standard/lightmode/spinner.e2e.ts          | 6 +++---
 4 files changed, 12 insertions(+), 6 deletions(-)

diff --git a/packages/core/src/components/spinner/test/inverted/darkmode/spinner.e2e.ts b/packages/core/src/components/spinner/test/inverted/darkmode/spinner.e2e.ts
index 00e88cd4d..c838b8112 100644
--- a/packages/core/src/components/spinner/test/inverted/darkmode/spinner.e2e.ts
+++ b/packages/core/src/components/spinner/test/inverted/darkmode/spinner.e2e.ts
@@ -4,9 +4,11 @@ import { expect } from '@playwright/test';
 const componentTestPath = 'src/components/spinner/test/inverted/darkmode/index.html';
 
 test.describe.parallel('tds-spinner-inverted-darkmode', () => {
-  test('renders inverted spinner correctly', async ({ page }) => {
+  test.beforeEach(async ({ page }) => {
     await page.goto(componentTestPath);
+  });
 
+  test('renders inverted spinner correctly', async ({ page }) => {
     /* Check diff on screenshot */
     await expect(page).toHaveScreenshot({ maxDiffPixels: 0 });
   });
diff --git a/packages/core/src/components/spinner/test/inverted/lightmode/spinner.e2e.ts b/packages/core/src/components/spinner/test/inverted/lightmode/spinner.e2e.ts
index a007e38d1..4ee977aa9 100644
--- a/packages/core/src/components/spinner/test/inverted/lightmode/spinner.e2e.ts
+++ b/packages/core/src/components/spinner/test/inverted/lightmode/spinner.e2e.ts
@@ -4,9 +4,11 @@ import { expect } from '@playwright/test';
 const componentTestPath = 'src/components/spinner/test/inverted/lightmode/index.html';
 
 test.describe.parallel('tds-spinner-inverted-lightmode', () => {
-  test('renders inverted spinner correctly', async ({ page }) => {
+  test.beforeEach(async ({ page }) => {
     await page.goto(componentTestPath);
+  });
 
+  test('renders inverted spinner correctly', async ({ page }) => {
     /* Check diff on screenshot */
     await expect(page).toHaveScreenshot({ maxDiffPixels: 0 });
   });
diff --git a/packages/core/src/components/spinner/test/standard/darkmode/spinner.e2e.ts b/packages/core/src/components/spinner/test/standard/darkmode/spinner.e2e.ts
index 84a4c4fd0..cc7a61ca2 100644
--- a/packages/core/src/components/spinner/test/standard/darkmode/spinner.e2e.ts
+++ b/packages/core/src/components/spinner/test/standard/darkmode/spinner.e2e.ts
@@ -4,9 +4,11 @@ import { expect } from '@playwright/test';
 const componentTestPath = 'src/components/spinner/test/standard/darkmode/index.html';
 
 test.describe.parallel('tds-spinner-standard-darkmode', () => {
-  test('renders basic spinner correctly', async ({ page }) => {
+  test.beforeEach(async ({ page }) => {
     await page.goto(componentTestPath);
+  });
 
+  test('renders basic spinner correctly', async ({ page }) => {
     /* Check diff on screenshot */
     await expect(page).toHaveScreenshot({ maxDiffPixels: 0 });
   });
diff --git a/packages/core/src/components/spinner/test/standard/lightmode/spinner.e2e.ts b/packages/core/src/components/spinner/test/standard/lightmode/spinner.e2e.ts
index 461821052..49cec7e60 100644
--- a/packages/core/src/components/spinner/test/standard/lightmode/spinner.e2e.ts
+++ b/packages/core/src/components/spinner/test/standard/lightmode/spinner.e2e.ts
@@ -4,16 +4,16 @@ import { expect } from '@playwright/test';
 const componentTestPath = 'src/components/spinner/test/standard/lightmode/index.html';
 
 test.describe.parallel('tds-spinner-standard-lightmode', () => {
-  test('renders basic spinner correctly', async ({ page }) => {
+  test.beforeEach(async ({ page }) => {
     await page.goto(componentTestPath);
+  });
 
+  test('renders basic spinner correctly', async ({ page }) => {
     /* Check diff on screenshot */
     await expect(page).toHaveScreenshot({ maxDiffPixels: 0 });
   });
 
   test('Check if animation is present', async ({ page }) => {
-    await page.goto(componentTestPath);
-
     const spinner = page.locator('tds-spinner:first-child circle');
     const spinnerStyle = await spinner.evaluate((style) => getComputedStyle(style).animationName);
     expect(spinnerStyle).toBe('dash');