Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: bnwlkr/Teller
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: scanion/Teller
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 7 commits
  • 5 files changed
  • 1 contributor

Commits on Jul 23, 2021

  1. Additional templates for tabula

    @scanion
    scanion committed Jul 23, 2021
    Copy the full SHA
    8a9991e View commit details

  2. Grabs start year out of pdf text for credit and chequing/saving

    @scanion
    scanion committed Jul 23, 2021

    Verified

    This commit was signed with the committer’s verified signature.
    romtsn Roman Zavarnitsyn
    GPG key ID: 39E2D3942AD33477
    Verified
    Learn about vigilant mode
    Copy the full SHA
    57ba094 View commit details

  3. grabbing start year from pdf_text in parser. 

    Grabbing start year from filename was not reliable as there are different naming conventions from RBC's own site.  This gets around that completely.
    @scanion
    scanion committed Jul 23, 2021
    Copy the full SHA
    d39e35f View commit details

  4. Taking into account RBCs slight change in format

    @scanion
    scanion committed Jul 23, 2021
    Copy the full SHA
    13cbceb View commit details

  5. adding another case to pass. 

    This was failing on an entry of 
"7 ELEVEN"
It would add up string values of ELEVEN and go on.  At least not it has to be 3 characters.
    @scanion
    scanion committed Jul 23, 2021
    Copy the full SHA
    e63478f View commit details

Commits on Jul 24, 2021

  1. Looking up index of closing line

    @scanion
    scanion committed Jul 24, 2021
    Copy the full SHA
    ea4dc5d View commit details

  2. formatting

    @scanion
    scanion committed Jul 24, 2021
    Copy the full SHA
    64e7bee View commit details
Loading