fix bug where autocentroid would fail to index correctly if crop size was larger than frame size

Author: mileslucas

src/vampires_dpp/analysis.py

@@ -67,10 +67,6 @@ def safe_annulus_sum(frame, Rin, Rout, center=None):
     return flux[0], fluxerr[0]
 
 
-def estimate_strehl(*args, **kwargs):
-    raise NotImplementedError()
-
-
 def analyze_fields(
     cube,
     cube_err,

src/vampires_dpp/cli/centroids.py

@@ -124,9 +124,9 @@ def centroid(config: Path, filenames, num_proc, outdir, manual, plot):
             centroids = get_psf_centroids_manual(cams=cams, npsfs=npsfs)
 
     else:
-        name = paths.aux / f"{pipeline_config.name}_raw_psf"
+        name = paths.aux / f"{pipeline_config.name}_mean_image"
         # choose 4 to 20 files, depending on file size (avoid loading more than 500 frames, ~2GB of MBI)
-        number_files = int(max(4, min(10, 500 // table["NAXIS3"].median())))
+        number_files = int(max(2, min(10, 500 // table["NAXIS3"].median())))
         input_hduls_dict = create_raw_input_psfs(table, basename=name, max_files=number_files)
         centroids = {}
         for key, input_hdul in input_hduls_dict.items():

src/vampires_dpp/image_registration.py

@@ -409,7 +409,9 @@ def autocentroid_hdul(
         # find centroid of image with square scaling to help bias towards PSF
         rough_ctr = centroids.centroid_com(cutout.data**2, mask=np.isnan(cutout.data))
         # take a large crop, large enough to see satellite spots plus misregistration
-        rough_cutout = Cutout2D(cutout.data, rough_ctr, crop_size, mode="partial")
+        rough_cutout = Cutout2D(
+            cutout.data, rough_ctr, min(*cutout.shape[-2:], crop_size), mode="partial"
+        )
         # high-pass filter the data with a large median-- note, this requires the data to have
         # a certain level of S/N or it will wipe out the satellite spots. Therefore it's only suggested
         # to run the autocentroid on a big stack of mean-combined data instead of individual frames

src/vampires_dpp/pipeline/pipeline.py

@@ -176,6 +176,9 @@ def get_centroids(self):
         return self.centroids
 
     def get_reproject_tforms(self):
+        if not ("cam1" in self.centroids and "cam2" in self.centroids):
+            self.reproject_tforms = None
+            return self.reproject_tforms
         cam1_centroids = self.centroids["cam1"].copy()
         cam2_centroids = self.centroids["cam2"].copy()
         # flip cam1 on y!!