-
Notifications
You must be signed in to change notification settings - Fork 102
/
Changes5.001
1299 lines (1039 loc) · 46.9 KB
/
Changes5.001
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
-------------
Version 5.001
-------------
Nearly all the changes for 5.001 were bug fixes of one variety or another,
so here's the bug list, along with the "resolution" for each of them. If
you wish to correspond about any of them, please include the bug number.
There were a few that can be construed as enhancements:
NETaa13059: now warns of use of \1 where $1 is necessary.
NETaa13512: added $SIG{__WARN__} and $SIG{__DIE__} hooks
NETaa13520: added closures
NETaa13530: scalar keys now resets hash iterator
NETaa13641: added Tim's fancy new import whizbangers
NETaa13710: cryptswitch needed to be more "useable"
NETaa13716: Carp now allows multiple packages to be skipped out of
NETaa13716: now counts imported routines as "defined" for redef warnings
(and, of course, much of the stuff from the perl5-porters)
NETaa12974: README incorrectly said it was a pre-release.
Files patched: README
NETaa13033: goto pushed a bogus scope on the context stack.
From: Steve Vinoski
Files patched: pp_ctl.c
The goto operator pushed an extra bogus scope onto the context stack. (This
often didn't matter, since many things pop extra unrecognized scopes off.)
NETaa13034: tried to get valid pointer from undef.
From: Castor Fu
Also: Achille Hui, the Day Dreamer
Also: Eric Arnold
Files patched: pp_sys.c
Now treats undef specially, and calls SvPV_force on any non-numeric scalar
value to get a real pointer to somewhere.
NETaa13035: included package info with filehandles.
From: Jack Shirazi - BIU
Files patched: pp_hot.c pp_sys.c
Now passes a glob to filehandle methods to keep the package info intact.
NETaa13048: didn't give strict vars message on every occurrence.
From: Doug Campbell
Files patched: gv.c
It now complains about every occurrence. (The bug resulted from an
ill-conceived attempt to suppress a duplicate error message in a
suboptimal fashion.)
NETaa13052: test for numeric sort sub return value fooled by taint magic.
From: Peter Jaspers-Fayer
Files patched: pp_ctl.c sv.h
The test to see if the sort sub return value was numeric looked at the
public flags rather than the private flags of the SV, so taint magic
hid that info from the sort.
NETaa13053: forced a2p to use byacc
From: Andy Dougherty
Files patched: MANIFEST x2p/Makefile.SH x2p/a2p.c
a2p.c is now pre-byacced and shipped with the kit.
NETaa13055: misnamed constant in previous patch.
From: Conrad Augustin
Files patched: op.c op.h toke.c
The tokener translates $[ to a constant, but with a special marking in case
the constant gets assigned to or localized. Unfortunately, the marking
was done with a combination of OPf_SPECIAL and OPf_MOD that was easily
spoofed. There is now a private OPpCONST_ARYLEN flag for this purpose.
NETaa13055: use of OPf_SPECIAL for $[ lvaluehood was too fragile.
Files patched: op.c op.h toke.c
(same)
NETaa13056: convert needs to throw away any number info on its list.
From: Jack Shirazi - BIU
Files patched: op.c
The listiness of the argument list leaked out to the subroutine call because
of how prepend_elem and append_elem reuse an existing list. The convert()
routine just needs to discard any listiness it finds on its argument.
NETaa13058: AUTOLOAD shouldn't assume size of @_ is meaningful.
From: Florent Guillaume
Files patched: ext/DB_File/DB_File.pm ext/Fcntl/Fcntl.pm ext/GDBM_File/GDBM_File.pm ext/Socket/Socket.pm h2xs.SH
I just deleted the optimization, which is silly anyway since the eventual
subroutine definition is cached.
NETaa13059: now warns of use of \1 where $1 is necessary.
From: Gustaf Neumann
Files patched: toke.c
Now says
Can't use \1 to mean $1 in expression at foo line 2
along with an explanation in perldiag.
NETaa13060: no longer warns on attempt to read <> operator's transition state.
From: Chaim Frenkel
Files patched: pp_hot.c
No longer warns on <> operator's transitional state.
NETaa13140: warning said $ when @ would be more appropriate.
From: David J. MacKenzie
Files patched: op.c pod/perldiag.pod
Now says
(Did you mean $ or @ instead of %?)
and added more explanation to perldiag.
NETaa13149: was reading freed memory to make incorrect error message.
Files patched: pp_ctl.c
It was reading freed memory to make an error message that would be
incorrect in any event because it had the inner filename rather than
the outer.
NETaa13149: confess was sometimes less informative than croak
From: Jack Shirazi
Files patched: lib/Carp.pm
(same)
NETaa13150: stderr needs to be STDERR in package
From: Jack Shirazi
Files patched: lib/File/CheckTree.pm
Also fixed pl2pm to translate the filehandles to uppercase.
NETaa13150: uppercases stdin, stdout and stderr
Files patched: pl2pm
(same)
NETaa13154: array assignment didn't notice package magic.
From: Brian Reichert
Files patched: pp_hot.c
The list assignment operator looked for only set magic, but set magic is
only on the elements of a magical hash, not on the hash as a whole. I made
the operator look for any magic at all on the target array or hash.
NETaa13155: &DB::DB left trash on the stack.
From: Thomas Koenig
Files patched: lib/perl5db.pl pp_ctl.c
The call by pp_dbstate() to &DB::DB left trash on the stack. It now
calls DB in list context, and DB returns ().
NETaa13156: lexical variables didn't show up in debugger evals.
From: Joergen Haegg
Files patched: op.c
The code that searched back up the context stack for the lexical scope
outside the eval only partially took into consideration that there
might be extra debugger subroutine frames that shouldn't be used, and
ended up comparing the wrong statement sequence number to the range of
valid sequence numbers for the scope of the lexical variable. (There
was also a bug fixed in passing that caused the scope of lexical to go
clear to the end of the subroutine even if it was within an inner block.)
NETaa13157: any request for autoloaded DESTROY should create a null one.
From: Tom Christiansen
Files patched: lib/AutoLoader.pm
If DESTROY.al is not located, it now creates sub DESTROY {} automatically.
NETaa13158: now preserves $@ around destructors while leaving eval.
From: Tim Bunce
Files patched: pp_ctl.c
Applied supplied patch, except the whole second hunk can be replaced with
sv_insert(errsv, 0, 0, message, strlen(message));
NETaa13160: clarified behavior of split without arguments
From: Harry Edmon
Files patched: pod/perlfunc.pod
Clarified the behavior of split without arguments.
NETaa13162: eval {} lost list/scalar context
From: Dov Grobgeld
Files patched: op.c
LEAVETRY didn't propagate number to ENTERTRY.
NETaa13163: clarified documentation of foreach using my variable
From: Tom Christiansen
Files patched: pod/perlsyn.pod
Explained that foreach using a lexical is still localized.
NETaa13164: the dot detector for the end of formats was over-rambunctious.
From: John Stoffel
Files patched: toke.c
The dot detector for the end of formats was over-rambunctious. It would
pick up any dot that didn't have a space in front of it.
NETaa13165: do {} while 1 never linked outer block into next chain.
From: Gisle Aas
Files patched: op.c
When the conditional of do {} while 1; was optimized away, it confused the
postfix order construction so that the block that ordinarily sits around the
whole loop was never executed. So when the loop tried to unstack between
iterations, it got the wrong context, and blew away the lexical variables
of the outer scope. Fixed it by introducing a NULL opcode that will be
optimized away later.
NETaa13167: coercion was looking at public bits rather than private bits.
From: Randal L. Schwartz
Also: Thomas Riechmann
Also: Shane Castle
Files patched: sv.c
There were some bad ifdefs around the various varieties of set*id(). In
addition, tainting was interacting badly with assignment to $> because
sv_2iv() was examining SvPOK rather than SvPOKp, and so couldn't coerce
a string uid to an integer one.
NETaa13167: had some ifdefs wrong on set*id.
Files patched: mg.c pp_hot.c
(same)
NETaa13168: relaxed test for comparison of new and old fds
From: Casper H.S. Dik
Files patched: t/lib/posix.t
I relaxed the comparison to just check that the new fd is greater.
NETaa13169: autoincrement can corrupt scalar value state.
From: Gisle Aas
Also: Tom Christiansen
Files patched: sv.c
It assumed a PV didn't need to be upgraded to become an NV.
NETaa13169: previous patch could leak a string pointer.
Files patched: sv.c
(same)
NETaa13170: symbols missing from global.sym
From: Tim Bunce
Files patched: global.sym
Applied suggested patch.
NETaa13171: \\ in <<'END' shouldn't reduce to \.
From: Randal L. Schwartz
Files patched: toke.c
<<'END' needed to bypass ordinary single-quote processing.
NETaa13172: 'use integer' turned off magical autoincrement.
From: Erich Rickheit KSC
Files patched: pp.c pp_hot.c
The integer versions of the increment and decrement operators were trying too
hard to be efficient.
NETaa13172: deleted duplicate increment and decrement code
Files patched: opcode.h opcode.pl pp.c
(same)
NETaa13173: install should make shared libraries executable.
From: Brian Grossman
Also: Dave Nadler
Also: Eero Pajarre
Files patched: installperl
Now gives permission 555 to any file ending with extension specified by $dlext.
NETaa13176: ck_rvconst didn't free the const it used up.
From: Nick Duffek
Files patched: op.c
I checked in many random memory leaks under this bug number, since it
was an eval that brought many of them out.
NETaa13176: didn't delete XRV for temp ref of destructor.
Files patched: sv.c
(same)
NETaa13176: didn't delete op_pmshort in matching operators.
Files patched: op.c
(same)
NETaa13176: eval leaked the name of the eval.
Files patched: scope.c
(same)
NETaa13176: gp_free didn't free the format.
Files patched: gv.c
(same)
NETaa13176: minor leaks in loop exits and constant subscript optimization.
Files patched: op.c
(same)
NETaa13176: plugged some duplicate struct allocation memory leaks.
Files patched: perl.c
(same)
NETaa13176: sv_clear of an FM didn't clear anything.
Files patched: sv.c
(same)
NETaa13176: tr/// didn't mortalize its return value.
Files patched: pp.c
(same)
NETaa13177: SCOPE optimization hid line number info
From: David J. MacKenzie
Also: Hallvard B Furuseth
Files patched: op.c
Every pass on the syntax tree has to keep track of the current statement.
Unfortunately, the single-statement block was optimized into a single
statement between the time the variable was parsed and the time the
void code scan was done, so that pass didn't see the OP_NEXTSTATE
operator, because it has been optimized to an OP_NULL.
Fortunately, null operands remember what they were, so it was pretty easy
to make it set the correct line number anyway.
NETaa13178: some linux doesn't handle nm well
From: Alan Modra
Files patched: hints/linux.sh
Applied supplied patch.
NETaa13180: localized slice now pre-extends array
From: Larry Schuler
Files patched: pp.c
A localized slice now pre-extends its array to avoid reallocation during
the scope of the local.
NETaa13181: m//g didn't keep track of whether previous match matched null.
From: "philippe.verdret"
Files patched: mg.h pp_hot.c
A pattern isn't allowed to match a null string in the same place twice in
a row. m//g wasn't keeping track of whether the previous match matched
the null string.
NETaa13182: now includes whitespace as a regexp metacharacter.
From: Larry Wall
Files patched: toke.c
scan_const() now counts " \t\n\r\f\v" as metacharacters when scanning a pattern.
NETaa13183: sv_setsv shouldn't try to clone an object.
From: Peter Gordon
Files patched: sv.c
The sv_mortalcopy() done by the return in STORE called sv_setsv(),
which cloned the object. sv_setsv() shouldn't be in the business of
cloning objects.
NETaa13184: bogus warning on quoted signal handler name removed.
From: Dan Carson
Files patched: toke.c
Now doesn't complain unless the first non-whitespace character after the =
is an alphabetic character.
NETaa13186: now croaks on chop($')
From: Casper H.S. Dik
Files patched: doop.c
Now croaks on chop($') and such.
NETaa13187: "${foo::bar}" now counts as mere delimitation, not as a bareword.
From: Jay Rogers
Files patched: toke.c
"${foo::bar}" now counts as mere delimitation, not as a bareword inside a
reference block.
NETaa13188: for backward compatibility, looks for "perl -" before "perl".
From: Russell Mosemann
Files patched: toke.c
Now allows non-whitespace characters on the #! line between the "perl"
and the "-".
NETaa13188: now allows non-whitespace after #!...perl before switches.
Files patched: toke.c
(same)
NETaa13189: derivative files need to be removed before recreation
From: Simon Leinen
Also: Dick Middleton
Also: David J. MacKenzie
Files patched: embed_h.sh x2p/Makefile.SH
Fixed various little nits as suggested in several messages.
NETaa13190: certain assignments can spoof pod directive recognizer
From: Ilya Zakharevich
Files patched: toke.c
The lexer now only recognizes pod directives where a statement is expected.
NETaa13194: now returns undef when there is no curpm.
From: lusol@Dillon.CC.Lehigh.EDU
Files patched: mg.c
Since there was no regexp prior to the "use", it was returning whatever the
last successful match was within the "use", because there was no current
regexp, so it treated it as a normal variable. It now returns undef.
NETaa13195: semop had one S too many.
From: Joachim Huober
Files patched: opcode.pl
The entry in opcode.pl had one too many S's.
NETaa13196: always assumes it's a Perl script if -c is used.
From: Dan Carson
Files patched: toke.c
It now will assume it's a Perl script if the -c switch is used.
NETaa13197: changed implicit -> message to be more understandable.
From: Bruce Barnett
Files patched: op.c pod/perldiag.pod
I changed the error message to be more understandable. It now says
Can't use subscript on sort...
NETaa13201: added OPpCONST_ENTERED flag to properly enter filehandle symbols.
From: E. Jay Berkenbilt
Also: Tom Christiansen
Files patched: op.c op.h toke.c
The grammatical reduction of a print statement didn't properly count
the filehandle as a symbol reference because it couldn't distinguish
between a symbol entered earlier in the program and a symbol entered
for the first time down in the lexer.
NETaa13203: README shouldn't mention uperl.o any more.
From: Anno Siegel
Files patched: README
NETaa13204: .= shouldn't warn on uninitialized target.
From: Pete Peterson
Files patched: pp_hot.c
No longer warns on uninitialized target of .= operator.
NETaa13206: handy macros in XSUB.h
From: Tim Bunce
Files patched: XSUB.h
Added suggested macros.
NETaa13228: commonality checker didn't treat lexicals as variables.
From: mcook@cognex.com
Files patched: op.c opcode.pl
The list assignment operator tries to avoid unnecessary copies by doing the
assignment directly if there are no common variables on either side of the
equals. Unfortunately, the code that decided that only recognized references
to dynamic variables, not lexical variables.
NETaa13229: fixed sign stuff for complement, integer coercion.
From: Larry Wall
Files patched: perl.h pp.c sv.c
Fixed ~0 and integer coercions.
NETaa13230: no longer tries to reuse scratchpad temps if tainting in effect.
From: Luca Fini
Files patched: op.c
I haven't reproduced it, but I believe the problem is the reuse of scratchpad
temporaries between statements. I've made it not try to reuse them if
tainting is in effect.
NETaa13231: *foo = *bar now prevents typo warnings on "foo"
From: Robin Barker
Files patched: sv.c
Aliasing of the form *foo = *bar is now protected from the typo warnings.
Previously only the *foo = \$bar form was.
NETaa13235: require BAREWORD now introduces package name immediately.
From: Larry Wall
Files patched: toke.c
require BAREWORD now introduces package name immediately. This lets the
method intuit code work right even though the require hasn't actually run
yet.
NETaa13289: didn't calculate correctly using arybase.
From: Jared Rhine
Files patched: pp.c pp_hot.c
The runtime code didn't use curcop->cop_arybase correctly.
NETaa13301: store now throws exception on error
From: Barry Friedman
Files patched: ext/GDBM_File/GDBM_File.xs ext/NDBM_File/NDBM_File.xs ext/ODBM_File/ODBM_File.xs ext/SDBM_File/SDBM_File.xs
Changed warn to croak in ext/*DBM_File/*.xs.
NETaa13302: ctime now takes Time_t rather than Time_t*.
From: Rodger Anderson
Files patched: ext/POSIX/POSIX.xs
Now declares a Time_t and takes the address of that in CODE.
NETaa13302: shorter way to do this patch
Files patched: ext/POSIX/POSIX.xs
(same)
NETaa13304: could feed too large $@ back into croak, whereupon it croaked.
From: Larry Wall
Files patched: perl.c
callist() could feed $@ back into croak with more than a bare %s. (croak()
handles long strings with a bare %s okay.)
NETaa13305: compiler misoptimized RHS to outside of s/a/print/e
From: Brian S. Cashman <bsc@umich.edu>
Files patched: op.c
The syntax tree was being misconstructed because the compiler felt that
the RHS was invariant, so it did it outside the s///.
NETaa13314: assigning mortal to lexical leaks
From: Larry Wall
Files patched: sv.c
In stealing strings, sv_setsv was checking SvPOK to see if it should free
the destination string. It should have been checking SvPVX.
NETaa13316: wait4pid now recalled when errno == EINTR
From: Robert J. Pankratz
Files patched: pp_sys.c util.c
system() and the close() of a piped open now recall wait4pid if it returned
prematurely with errno == EINTR.
NETaa13329: needed to localize taint magic
From: Brian Katzung
Files patched: sv.c doio.c mg.c pp_hot.c pp_sys.c scope.c taint.c
Taint magic is now localized better, though I had to resort to a kludge
to allow a value to be both tainted and untainted simultaneously during
the assignment of
local $foo = $_[0];
when $_[0] is a reference to the variable $foo already.
NETaa13341: clarified interaction of AnyDBM_File::ISA and "use"
From: Ian Phillipps
Files patched: pod/modpods/AnyDBMFile.pod
The doc was misleading.
NETaa13342: grep and map with block would enter block but never leave it.
From: Ian Phillipps
Files patched: op.c
The compiler use some sort-checking code to handle the arguments of
grep and map. Unfortunately, this wiped out the block exit opcode while
leaving the block entry opcode. This doesn't matter to sort, but did
matter to grep and map. It now leave the block entry intact.
The reason it worked without the my is because the block entry and exit
were optimized away to an OP_SCOPE, which it doesn't matter if it's there
or not.
NETaa13343: goto needed to longjmp when in a signal handler.
From: Robert Partington
Files patched: pp_ctl.c
goto needed to longjmp() when in a signal handler to get back into the
right run() context.
NETaa13344: strict vars shouldn't apply to globs or filehandles.
From: Andrew Wilcox
Files patched: gv.c
Filehandles and globs will be excepted from "strict vars", so that you can
do the standard Perl 4 trick of
use strict;
sub foo {
local(*IN);
open(IN,"file");
}
NETaa13345: assert.pl didn't use package DB
From: Hans Mulder
Files patched: lib/assert.pl
Now it does.
NETaa13348: av_undef didn't free scalar representing $#foo.
From: David Filo
Files patched: av.c
av_undef didn't free scalar representing $#foo.
NETaa13349: sort sub accumulated save stack entries
From: David Filo
Files patched: pp_ctl.c
COMMON only gets set if assigning to @_, which is reasonable. Most of the
problem was a memory leak.
NETaa13351: didn't treat indirect filehandles as references.
From: Andy Dougherty
Files patched: op.c
Now produces
Can't use an undefined value as a symbol reference at ./foo line 3.
NETaa13352: OP_SCOPE allocated as UNOP rather than LISTOP.
From: Andy Dougherty
Files patched: op.c
NETaa13353: scope() didn't release filegv on OP_SCOPE optimization.
From: Larry Wall
Files patched: op.c
When scope() nulled out a NEXTSTATE, it didn't release its filegv reference.
NETaa13355: hv_delete now avoids useless mortalcopy
From: Larry Wall
Files patched: hv.c op.c pp.c pp_ctl.c proto.h scope.c util.c
hv_delete now avoids useless mortalcopy.
NETaa13359: comma operator section missing its heading
From: Larry Wall
Files patched: pod/perlop.pod
NETaa13359: random typo
Files patched: pod/perldiag.pod
NETaa13360: code to handle partial vec values was bogus.
From: Conrad Augustin
Files patched: pp.c
The code that Mark J. added a long time ago to handle values that were partially
off the end of the string was incorrect.
NETaa13361: made it not interpolate inside regexp comments
From: Martin Jost
Files patched: toke.c
To avoid surprising people, it no longer interpolates inside regexp
comments.
NETaa13362: ${q[1]} should be interpreted like it used to
From: Hans Mulder
Files patched: toke.c
Now resolves ${keyword[1]} to $keyword[1] and warns if -w. Likewise for {}.
NETaa13363: meaning of repeated search chars undocumented in tr///
From: Stephen P. Potter
Files patched: pod/perlop.pod
Documented that repeated characters use the first translation given.
NETaa13365: if closedir fails, don't try it again.
From: Frank Crawford
Files patched: pp_sys.c
Now does not attempt to closedir a second time.
NETaa13366: can't do block scope optimization on $1 et al when tainting.
From: Andrew Vignaux
Files patched: toke.c
The tainting mechanism assumes that every statement starts out
untainted. Unfortunately, the scope removal optimization for very
short blocks removed the statementhood of statements that were
attempting to read $1 as an untainted value, with the effect that $1
appeared to be tainted anyway. The optimization is now disabled when
tainting and the block contains $1 (or equivalent).
NETaa13366: fixed this a better way in toke.c.
Files patched: op.c
(same)
NETaa13366: need to disable scope optimization when tainting.
Files patched: op.c
(same)
NETaa13367: Did a SvCUR_set without nulling out final char.
From: "Rob Henderson" <robh@cs.indiana.edu>
Files patched: doop.c pp.c pp_sys.c
When do_vop set the length on its result string it neglected to null-terminate
it.
NETaa13368: bigrat::norm sometimes chucked sign
From: Greg Kuperberg
Files patched: lib/bigrat.pl
The normalization routine was assuming that the gcd of two numbers was
never negative, and based on that assumption managed to move the sign
to the denominator, where it was deleted on the assumption that the
denominator is always positive.
NETaa13368: botched previous patch
Files patched: lib/bigrat.pl
(same)
NETaa13369: # is now a comment character, and \# should be left for regcomp.
From: Simon Parsons
Files patched: toke.c
It was not skipping the comment when it skipped the white space, and constructed
an opcode that tried to match a null string. Unfortunately, the previous
star tried to use the first character of the null string to optimize where
to recurse, so it never matched.
NETaa13369: comment after regexp quantifier induced non-match.
Files patched: regcomp.c
(same)
NETaa13370: some code assumed SvCUR was of type int.
From: Spider Boardman
Files patched: pp_sys.c
Did something similar to the proposed patch. I also fixed the problem that
it assumed the type of SvCUR was int. And fixed get{peer,sock}name the
same way.
NETaa13375: sometimes dontbother wasn't added back into strend.
From: Jamshid Afshar
Files patched: regexec.c
When the /g modifier was used, the regular expression code would calculate
the end of $' too short by the minimum number of characters the pattern could
match.
NETaa13375: sv_setpvn now disallows negative length.
Files patched: sv.c
(same)
NETaa13376: suspected indirect objecthood prevented recognition of lexical.
From: Gisle.Aas@nr.no
Files patched: toke.c
When $data[0] is used in a spot that might be an indirect object, the lexer
was getting confused over the rule that says the $data in $$data[0] isn't
an array element. (The lexer uses XREF state for both indirect objects
and for variables used as names.)
NETaa13377: -I processesing ate remainder of #! line.
From: Darrell Schiebel
Files patched: perl.c
I made the -I processing in moreswitches look for the end of the string,
delimited by whitespace.
NETaa13379: ${foo} now treated the same outside quotes as inside
From: Hans Mulder
Files patched: toke.c
${bareword} is now treated the same outside quotes as inside.
NETaa13379: previous fix for this bug was botched
Files patched: toke.c
(same)
NETaa13381: TEST should check for perl link
From: Andy Dougherty
Files patched: t/TEST
die "You need to run \"make test\" first to set things up.\n" unless -e 'perl';
NETaa13384: fixed version 0.000 botch.
From: Larry Wall
Files patched: installperl
NETaa13385: return 0 from required file loses message
From: Malcolm Beattie
Files patched: pp_ctl.c
Works right now.
NETaa13387: added pod2latex
From: Taro KAWAGISHI
Files patched: MANIFEST pod/pod2latex
Added most recent copy to pod directory.
NETaa13388: constant folding now prefers integer results over double
From: Ilya Zakharevich
Files patched: op.c
Constant folding now prefers integer results over double.
NETaa13389: now treats . and exec as shell metathingies
From: Hans Mulder
Files patched: doio.c
Now treats . and exec as shell metathingies.
NETaa13395: eval didn't check taintedness.
From: Larry Wall
Files patched: pp_ctl.c
NETaa13396: $^ coredumps at end of string
From: Paul Rogers
Files patched: toke.c
The scan_ident() didn't check for a null following $^.
NETaa13397: improved error messages when operator expected
From: Larry Wall
Files patched: toke.c
Added message (Do you need to predeclare BAR?). Also fixed the missing
semicolon message.
NETaa13399: cleanup by Andy
From: Larry Wall
Files patched: Changes Configure Makefile.SH README cflags.SH config.H config_h.SH deb.c doop.c dump.c ext/DB_File/DB_File.pm ext/DB_File/DB_File.xs ext/DynaLoader/DynaLoader.pm ext/Fcntl/Fcntl.pm ext/GDBM_File/GDBM_File.pm ext/POSIX/POSIX.pm ext/SDBM_File/sdbm/sdbm.h ext/Socket/Socket.pm ext/util/make_ext h2xs.SH hints/aix.sh hints/bsd386.sh hints/dec_osf.sh hints/esix4.sh hints/freebsd.sh hints/irix_5.sh hints/next_3_2.sh hints/sunos_4_1.sh hints/svr4.sh hints/ultrix_4.sh installperl lib/AutoSplit.pm lib/Cwd.pm lib/ExtUtils/MakeMaker.pm lib/ExtUtils/xsubpp lib/Term/Cap.pm mg.c miniperlmain.c perl.c perl.h perl_exp.SH pod/Makefile pod/perldiag.pod pod/pod2html pp.c pp_ctl.c pp_hot.c pp_sys.c proto.h sv.h t/re_tests util.c x2p/Makefile.SH x2p/a2p.h x2p/a2py.c x2p/handy.h x2p/hash.c x2p/hash.h x2p/str.c x2p/str.h x2p/util.c x2p/util.h x2p/walk.c
NETaa13399: cleanup from Andy
Files patched: MANIFEST
NETaa13399: configuration cleanup
Files patched: Configure Configure MANIFEST MANIFEST Makefile.SH Makefile.SH README config.H config.H config_h.SH config_h.SH configpm ext/DynaLoader/DynaLoader.pm ext/DynaLoader/dl_hpux.xs ext/NDBM_File/Makefile.PL ext/ODBM_File/Makefile.PL ext/util/make_ext handy.h hints/aix.sh hints/hpux_9.sh hints/hpux_9.sh hints/irix_4.sh hints/linux.sh hints/mpeix.sh hints/next_3_2.sh hints/solaris_2.sh hints/svr4.sh installperl installperl lib/AutoSplit.pm lib/ExtUtils/MakeMaker.pm lib/ExtUtils/MakeMaker.pm lib/ExtUtils/xsubpp lib/Getopt/Long.pm lib/Text/Tabs.pm makedepend.SH makedepend.SH mg.c op.c perl.h perl_exp.SH pod/perl.pod pod/perldiag.pod pod/perlsyn.pod pod/pod2man pp_sys.c proto.h proto.h unixish.h util.c util.c vms/config.vms writemain.SH x2p/a2p.h x2p/a2p.h x2p/a2py.c x2p/a2py.c x2p/handy.h x2p/util.c x2p/walk.c x2p/walk.c
NETaa13399: new files from Andy
Files patched: ext/DB_File/Makefile.PL ext/DynaLoader/Makefile.PL ext/Fcntl/Makefile.PL ext/GDBM_File/Makefile.PL ext/NDBM_File/Makefile.PL ext/ODBM_File/Makefile.PL ext/POSIX/Makefile.PL ext/SDBM_File/Makefile.PL ext/SDBM_File/sdbm/Makefile.PL ext/Socket/Makefile.PL globals.c hints/convexos.sh hints/irix_6.sh
NETaa13399: patch0l from Andy
Files patched: Configure MANIFEST Makefile.SH config.H config_h.SH ext/DB_File/Makefile.PL ext/GDBM_File/Makefile.PL ext/NDBM_File/Makefile.PL ext/POSIX/POSIX.xs ext/SDBM_File/sdbm/Makefile.PL ext/util/make_ext h2xs.SH hints/next_3_2.sh hints/solaris_2.sh hints/unicos.sh installperl lib/Cwd.pm lib/ExtUtils/MakeMaker.pm makeaperl.SH vms/config.vms x2p/util.c x2p/util.h
NETaa13399: stuff from Andy
Files patched: Configure MANIFEST Makefile.SH configpm hints/dec_osf.sh hints/linux.sh hints/machten.sh lib/ExtUtils/MakeMaker.pm util.c
NETaa13399: Patch 0k from Andy
Files patched: Configure MANIFEST Makefile.SH config.H config_h.SH hints/dec_osf.sh hints/mpeix.sh hints/next_3_0.sh hints/ultrix_4.sh installperl lib/ExtUtils/MakeMaker.pm lib/File/Path.pm makeaperl.SH minimod.PL perl.c proto.h vms/config.vms vms/ext/MM_VMS.pm x2p/a2p.h
NETaa13399: Patch 0m from Andy
Files patched: Configure MANIFEST Makefile.SH README config.H config_h.SH ext/DynaLoader/README ext/POSIX/POSIX.xs ext/SDBM_File/sdbm/sdbm.h ext/util/extliblist hints/cxux.sh hints/linux.sh hints/powerunix.sh lib/ExtUtils/MakeMaker.pm malloc.c perl.h pp_sys.c util.c
NETaa13400: pod2html update from Bill Middleton
From: Larry Wall
Files patched: pod/pod2html
NETaa13401: Boyer-Moore code attempts to compile string longer than 255.
From: Kyriakos Georgiou
Files patched: util.c
The Boyer-Moore table uses unsigned char offsets, but the BM compiler wasn't
rejecting strings longer than 255 chars, and was miscompiling them.
NETaa13403: missing a $ on variable name
From: Wayne Scott
Files patched: installperl
Yup, it was missing.
NETaa13406: didn't wipe out dead match when proceeding to next BRANCH
From: Michael P. Clemens
Files patched: regexec.c
The code to check alternatives didn't invalidate backreferences matched by the
failed branch.
NETaa13407: overload upgrade
From: owner-perl5-porters@nicoh.com
Also: Ilya Zakharevich
Files patched: MANIFEST gv.c lib/Math/BigInt.pm perl.h pod/perlovl.pod pp.c pp.h pp_hot.c sv.c t/lib/bigintpm.t t/op/overload.t
Applied supplied patch, and fixed bug induced by use of sv_setsv to do
a deep copy, since sv_setsv no longer copies objecthood.
NETaa13409: sv_gets tries to grow string at EOF
From: Harold O Morris
Files patched: sv.c
Applied suggested patch, only two statements earlier, since the end code
also does SvCUR_set.
NETaa13410: delaymagic did =~ instead of &= ~
From: Andreas Schwab
Files patched: pp_hot.c
Applied supplied patch.
NETaa13411: POSIX didn't compile under -DLEAKTEST
From: Frederic Chauveau
Files patched: ext/POSIX/POSIX.xs
Used NEWSV instead of newSV.
NETaa13412: new version from Tony Sanders
From: Tony Sanders
Files patched: lib/Term/Cap.pm
Installed as Term::Cap.pm
NETaa13413: regmust extractor needed to restart loop on BRANCH for (?:) to work
From: DESARMENIEN
Files patched: regcomp.c
The BRANCH skipper should have restarted the loop from the top.
NETaa13414: the check for accidental list context was done after pm_short check
From: Michael H. Coen
Files patched: pp_hot.c
Moved check for accidental list context to before the pm_short optimization.
NETaa13418: perlre.pod babbled nonsense about | in character classes
From: Philip Hazel
Files patched: pod/perlre.pod
Removed bogus brackets. Now reads:
Note however that "|" is interpreted as a literal with square brackets,
so if you write C<[fee|fie|foe]> you're really only matching C<[feio|]>.
NETaa13419: need to document introduction of lexical variables
From: "Heading, Anthony"
Files patched: pod/perlfunc.pod
Now mentions that lexicals aren't introduced till after the current statement.
NETaa13420: formats that overflowed a page caused endless top of forms
From: Hildo@CONSUL.NL
Files patched: pp_sys.c
If a record is too large to fit on a page, it now prints whatever will
fit and then calls top of form again on the remainder.
NETaa13423: the code to do negative list subscript in scalar context was missing
From: Steve McDougall
Files patched: pp.c
The negative subscript code worked right in list context but not in scalar
context. In fact, there wasn't code to do it in the scalar context.
NETaa13424: existing but undefined CV blocked inheritance
From: Spider Boardman
Files patched: gv.c
Applied supplied patch.
NETaa13425: removed extra argument to croak
From: "R. Bernstein"
Files patched: regcomp.c
Removed extra argument.
NETaa13427: added return types
From: "R. Bernstein"
Files patched: x2p/a2py.c
Applied suggested patch.
NETaa13427: added static declarations
Files patched: x2p/walk.c
(same)
NETaa13428: split was assuming that all backreferences were defined
From: Dave Schweisguth
Files patched: pp.c
split was assuming that all backreferences were defined.
NETaa13430: hoistmust wasn't hoisting anchored shortcircuit's length
From: Tom Christiansen
Also: Rob Hooft
Files patched: toke.c
NETaa13432: couldn't call code ref under debugger
From: Mike Fletcher
Files patched: op.c pp_hot.c sv.h
The debugging code assumed it could remember a name to represent a subroutine,
but anonymous subroutines don't have a name. It now remembers a CV reference
in that case.
NETaa13435: 1' dumped core
From: Larry Wall
Files patched: toke.c
Didn't check a pointer for nullness.
NETaa13436: print foo(123) didn't treat foo as subroutine
From: mcook@cognex.com
Files patched: toke.c
Now treats it as a subroutine rather than a filehandle.
NETaa13437: &$::foo didn't think $::foo was a variable name
From: mcook@cognex.com
Files patched: toke.c
Now treats $::foo as a global variable.
NETaa13439: referred to old package name
From: Tom Christiansen
Files patched: lib/Sys/Syslog.pm
Wasn't a strict refs problem after all. It was simply referring to package
syslog, which had been renamed to Sys::Syslog.
NETaa13440: stat operations didn't know what to do with glob or ref to glob
From: mcook@cognex.com
Files patched: doio.c pp_sys.c
Now knows about the kinds of filehandles returned by FileHandle constructors
and such.
NETaa13442: couldn't find name of copy of deleted symbol table entry
From: Spider Boardman
Files patched: gv.c gv.h
I did a much simpler fix. When gp_free notices that it's freeing the
master GV, it nulls out gp_egv. The GvENAME and GvESTASH macros know
to revert to gv if egv is null.
This has the advantage of not creating a reference loop.
NETaa13443: couldn't override an XSUB
From: William Setzer
Files patched: op.c
When the newSUB and newXS routines checked for whether the old sub was
defined, they only looked at CvROOT(cv), not CvXSUB(cv).
NETaa13443: needed to do same thing in newXS
Files patched: op.c
(same)
NETaa13444: -foo now doesn't warn unless sub foo is defined
From: Larry Wall
Files patched: toke.c
Made it not warn on -foo, unless there is a sub foo defined.
NETaa13451: in scalar context, pp_entersub now guarantees one item from XSUB
From: Nick Gianniotis
Files patched: pp_hot.c
The pp_entersub routine now guarantees that an XSUB in scalar context
returns one and only one value. If there are fewer, it pushes undef,
and if there are more, it returns the last one.
NETaa13457: now explicitly disallows printf format with 'n' or '*'.
From: lees@cps.msu.edu
Files patched: doop.c
Now says
Use of n in printf format not supported at ./foo line 3.
NETaa13458: needed to call SvPOK_only() in pp_substr
From: Wayne Scott
Files patched: pp.c
Needed to call SvPOK_only() in pp_substr.
NETaa13459: umask and chmod now warn about missing initial 0 even with paren
From: Andreas Koenig
Files patched: toke.c
Now skips parens as well as whitespace looking for argument.
NETaa13460: backtracking didn't work on .*? because reginput got clobbered
From: Andreas Koenig
Files patched: regexec.c
When .*? did a probe of the rest of the string, it clobbered reginput,
so the next call to match a . tried to match the newline and failed.
NETaa13475: \(@ary) now treats array as list of scalars
From: Tim Bunce
Files patched: op.c
The mod() routine now refrains from marking @ary as an lvalue if it's in parens
and is the subject of an OP_REFGEN.
NETaa13481: accept buffer wasn't aligned good enough
From: Holger Bechtold
Also: Christian Murphy
Files patched: pp_sys.c
Applied suggested patch.
NETaa13486: while (<>) now means while (defined($_ = <>))
From: Jim Balter
Files patched: op.c pod/perlop.pod
while (<HANDLE>) now means while (defined($_ = <HANDLE>)).
NETaa13500: needed DESTROY in FileHandle
From: Tim Bunce
Files patched: ext/POSIX/POSIX.pm
Added DESTROY method. Also fixed ungensym to use POSIX:: instead of _POSIX.
Removed ungensym from close method, since DESTROY should do that now.
NETaa13502: now complains if you use local on a lexical variable