Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecation and add PHP 8.x features #31

Open
mattiabasone opened this issue May 11, 2022 · 6 comments
Open

Remove deprecation and add PHP 8.x features #31

mattiabasone opened this issue May 11, 2022 · 6 comments

Comments

@mattiabasone
Copy link

Hi!
Any chances to merge PR #30?
I'm updating my application and using PHP 8.1 I'm getting some deprecation warning like the following one:

Deprecated: Return type of PhpCollection\AbstractMap::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /src/vendor/phpcollection/phpcollection/src/PhpCollection/AbstractMap.php on line 290
@jurgenhaas
Copy link

I'm seeing two more like these:

Deprecation Notice: Return type of PhpCollection\AbstractSequence::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /drupal/vendor/phpcollection/phpcollection/src/PhpCollection/AbstractSequence.php:356
Deprecation Notice: Return type of PhpCollection\AbstractSequence::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /drupal/vendor/phpcollection/phpcollection/src/PhpCollection/AbstractSequence.php:351

jurgenhaas added a commit to jurgenhaas/php-collection that referenced this issue Aug 30, 2022
jurgenhaas added a commit to jurgenhaas/php-collection that referenced this issue Aug 30, 2022
@jurgenhaas
Copy link

@schmittjoh is this project dead? Or is there any chance of getting the PR merged?

@mattiabasone
Copy link
Author

@schmittjoh is this project dead? Or is there any chance of getting the PR merged?

@jurgenhaas if you need a package, I forked the project and released a new version with these fixes here

@jurgenhaas
Copy link

Thanks @mattiabasone but it doesn't help because we're not using this package directly. It's cypresslab/gitelephant which brings it as a dependency and hence, this package should be fixed directly.

@jurgenhaas
Copy link

Looks like the other package is removing the dependency entirely, so I will just close my PR because I'm tired of getting reminded about it every morning.

@imunhatep
Copy link

Hey there, here is yet another fork 🔢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants