From cfa48b3cf0ed7095d1a4ed30e6cd270c61c60b5f Mon Sep 17 00:00:00 2001 From: Shana Moore Date: Mon, 22 Jul 2024 11:23:26 -0700 Subject: [PATCH 1/2] update github actions versions to avoid error: ".yarn-tarball.tgz: no space left on device" ref: https://assaydepot.slack.com/archives/C0313NK5NMA/p1713461713731049 --- .github/workflows/build-test-lint.yaml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/build-test-lint.yaml b/.github/workflows/build-test-lint.yaml index 998e9489..91ceaaa2 100644 --- a/.github/workflows/build-test-lint.yaml +++ b/.github/workflows/build-test-lint.yaml @@ -17,7 +17,7 @@ on: jobs: build: - uses: scientist-softserv/actions/.github/workflows/build.yaml@v0.0.18 + uses: scientist-softserv/actions/.github/workflows/build.yaml@v0.0.22 secrets: inherit with: platforms: 'linux/amd64' @@ -26,7 +26,7 @@ jobs: test: needs: build - uses: scientist-softserv/actions/.github/workflows/test.yaml@v0.0.18 + uses: scientist-softserv/actions/.github/workflows/test.yaml@v0.0.22 with: confdir: '/app/samvera/hyrax-webapp/solr/conf' webTarget: hyku-web @@ -35,7 +35,7 @@ jobs: lint: needs: build - uses: scientist-softserv/actions/.github/workflows/lint.yaml@v0.0.18 + uses: scientist-softserv/actions/.github/workflows/lint.yaml@v0.0.22 with: webTarget: hyku-web workerTarget: hyku-worker From 5e0148e1ce002ce365a6e632914af1d4291f976b Mon Sep 17 00:00:00 2001 From: Shana Moore Date: Mon, 22 Jul 2024 15:19:44 -0700 Subject: [PATCH 2/2] :bug: Ensure multiple? method is called correctly for new and existing records fix: Ensure multiple? method is called correctly for new and existing records - Updated the view logic to check if the instance responds to `multiple?` first. - If the instance does not respond, then check if the class responds to `multiple?`. - This ensures the correct method is called for both new and existing records, preventing method undefined errors. --- app/views/journal_articles/edit_fields/_date_created.html.erb | 2 +- app/views/records/edit_fields/_date_accepted.html.erb | 2 +- app/views/records/edit_fields/_date_available.html.erb | 2 +- app/views/records/edit_fields/_date_collected.html.erb | 2 +- app/views/records/edit_fields/_date_copyrighted.html.erb | 2 +- app/views/records/edit_fields/_date_created.html.erb | 2 +- app/views/records/edit_fields/_date_issued.html.erb | 2 +- app/views/records/edit_fields/_date_of_award.html.erb | 2 +- app/views/records/edit_fields/_date_published.html.erb | 2 +- app/views/records/edit_fields/_date_submitted.html.erb | 2 +- app/views/records/edit_fields/_date_updated.html.erb | 2 +- app/views/records/edit_fields/_date_valid.html.erb | 2 +- app/views/records/edit_fields/_default.html.erb | 2 +- app/views/records/edit_fields/_end_date.html.erb | 2 +- app/views/records/edit_fields/_event_date.html.erb | 2 +- app/views/records/edit_fields/_start_date.html.erb | 2 +- 16 files changed, 16 insertions(+), 16 deletions(-) diff --git a/app/views/journal_articles/edit_fields/_date_created.html.erb b/app/views/journal_articles/edit_fields/_date_created.html.erb index 449141f4..825c77e7 100644 --- a/app/views/journal_articles/edit_fields/_date_created.html.erb +++ b/app/views/journal_articles/edit_fields/_date_created.html.erb @@ -1,6 +1,6 @@ <% # use date picker %> -<% if f.object.class.multiple? key %> +<% f.object.try(:multiple?, key) || f.object.class.try(:multiple?, key) %> <%= f.input key, as: :multi_value, input_html: { data: { provide: 'datepicker', 'date-force-parse': 'false', 'date-autoclose': 'true' } }, required: f.object.required?(key) %> <% else %> <%= f.input key, input_html: { value: f.object.model[key]&.first, data: { provide: 'datepicker', 'date-force-parse': 'false', 'date-autoclose': 'true' } }, required: f.object.required?(key) %> diff --git a/app/views/records/edit_fields/_date_accepted.html.erb b/app/views/records/edit_fields/_date_accepted.html.erb index 738c00ee..968648d2 100644 --- a/app/views/records/edit_fields/_date_accepted.html.erb +++ b/app/views/records/edit_fields/_date_accepted.html.erb @@ -1,6 +1,6 @@ <% # use date picker %> -<% if f.object.class.multiple? key %> +<% f.object.try(:multiple?, key) || f.object.class.try(:multiple?, key) %> <%= f.input key, as: :multi_value, input_html: { data: { provide: 'datepicker', 'date-force-parse': 'false', 'date-autoclose': 'true' } }, required: f.object.required?(key) %> <% else %> <%= f.input key, input_html: { value: f.object.model[key].first, data: { provide: 'datepicker', 'date-force-parse': 'false', 'date-autoclose': 'true' } }, required: f.object.required?(key) %> diff --git a/app/views/records/edit_fields/_date_available.html.erb b/app/views/records/edit_fields/_date_available.html.erb index 738c00ee..968648d2 100644 --- a/app/views/records/edit_fields/_date_available.html.erb +++ b/app/views/records/edit_fields/_date_available.html.erb @@ -1,6 +1,6 @@ <% # use date picker %> -<% if f.object.class.multiple? key %> +<% f.object.try(:multiple?, key) || f.object.class.try(:multiple?, key) %> <%= f.input key, as: :multi_value, input_html: { data: { provide: 'datepicker', 'date-force-parse': 'false', 'date-autoclose': 'true' } }, required: f.object.required?(key) %> <% else %> <%= f.input key, input_html: { value: f.object.model[key].first, data: { provide: 'datepicker', 'date-force-parse': 'false', 'date-autoclose': 'true' } }, required: f.object.required?(key) %> diff --git a/app/views/records/edit_fields/_date_collected.html.erb b/app/views/records/edit_fields/_date_collected.html.erb index 738c00ee..968648d2 100644 --- a/app/views/records/edit_fields/_date_collected.html.erb +++ b/app/views/records/edit_fields/_date_collected.html.erb @@ -1,6 +1,6 @@ <% # use date picker %> -<% if f.object.class.multiple? key %> +<% f.object.try(:multiple?, key) || f.object.class.try(:multiple?, key) %> <%= f.input key, as: :multi_value, input_html: { data: { provide: 'datepicker', 'date-force-parse': 'false', 'date-autoclose': 'true' } }, required: f.object.required?(key) %> <% else %> <%= f.input key, input_html: { value: f.object.model[key].first, data: { provide: 'datepicker', 'date-force-parse': 'false', 'date-autoclose': 'true' } }, required: f.object.required?(key) %> diff --git a/app/views/records/edit_fields/_date_copyrighted.html.erb b/app/views/records/edit_fields/_date_copyrighted.html.erb index 738c00ee..968648d2 100644 --- a/app/views/records/edit_fields/_date_copyrighted.html.erb +++ b/app/views/records/edit_fields/_date_copyrighted.html.erb @@ -1,6 +1,6 @@ <% # use date picker %> -<% if f.object.class.multiple? key %> +<% f.object.try(:multiple?, key) || f.object.class.try(:multiple?, key) %> <%= f.input key, as: :multi_value, input_html: { data: { provide: 'datepicker', 'date-force-parse': 'false', 'date-autoclose': 'true' } }, required: f.object.required?(key) %> <% else %> <%= f.input key, input_html: { value: f.object.model[key].first, data: { provide: 'datepicker', 'date-force-parse': 'false', 'date-autoclose': 'true' } }, required: f.object.required?(key) %> diff --git a/app/views/records/edit_fields/_date_created.html.erb b/app/views/records/edit_fields/_date_created.html.erb index 00e0b36e..719929ee 100644 --- a/app/views/records/edit_fields/_date_created.html.erb +++ b/app/views/records/edit_fields/_date_created.html.erb @@ -1,6 +1,6 @@ <%# use date picker %> -<% if f.object.class.multiple? key %> +<% f.object.try(:multiple?, key) || f.object.class.try(:multiple?, key) %> <%= f.input key, as: :multi_value, input_html: { data: { provide: 'datepicker', 'date-force-parse': 'false', 'date-autoclose': 'true' } }, required: f.object.required?(key) %> <% else %> <%= f.input key, input_html: { value: f.object.model[key]&.first, data: { provide: 'datepicker', 'date-force-parse': 'false', 'date-autoclose': 'true' } }, required: f.object.required?(key) %> diff --git a/app/views/records/edit_fields/_date_issued.html.erb b/app/views/records/edit_fields/_date_issued.html.erb index 738c00ee..968648d2 100644 --- a/app/views/records/edit_fields/_date_issued.html.erb +++ b/app/views/records/edit_fields/_date_issued.html.erb @@ -1,6 +1,6 @@ <% # use date picker %> -<% if f.object.class.multiple? key %> +<% f.object.try(:multiple?, key) || f.object.class.try(:multiple?, key) %> <%= f.input key, as: :multi_value, input_html: { data: { provide: 'datepicker', 'date-force-parse': 'false', 'date-autoclose': 'true' } }, required: f.object.required?(key) %> <% else %> <%= f.input key, input_html: { value: f.object.model[key].first, data: { provide: 'datepicker', 'date-force-parse': 'false', 'date-autoclose': 'true' } }, required: f.object.required?(key) %> diff --git a/app/views/records/edit_fields/_date_of_award.html.erb b/app/views/records/edit_fields/_date_of_award.html.erb index 738c00ee..968648d2 100644 --- a/app/views/records/edit_fields/_date_of_award.html.erb +++ b/app/views/records/edit_fields/_date_of_award.html.erb @@ -1,6 +1,6 @@ <% # use date picker %> -<% if f.object.class.multiple? key %> +<% f.object.try(:multiple?, key) || f.object.class.try(:multiple?, key) %> <%= f.input key, as: :multi_value, input_html: { data: { provide: 'datepicker', 'date-force-parse': 'false', 'date-autoclose': 'true' } }, required: f.object.required?(key) %> <% else %> <%= f.input key, input_html: { value: f.object.model[key].first, data: { provide: 'datepicker', 'date-force-parse': 'false', 'date-autoclose': 'true' } }, required: f.object.required?(key) %> diff --git a/app/views/records/edit_fields/_date_published.html.erb b/app/views/records/edit_fields/_date_published.html.erb index 738c00ee..968648d2 100644 --- a/app/views/records/edit_fields/_date_published.html.erb +++ b/app/views/records/edit_fields/_date_published.html.erb @@ -1,6 +1,6 @@ <% # use date picker %> -<% if f.object.class.multiple? key %> +<% f.object.try(:multiple?, key) || f.object.class.try(:multiple?, key) %> <%= f.input key, as: :multi_value, input_html: { data: { provide: 'datepicker', 'date-force-parse': 'false', 'date-autoclose': 'true' } }, required: f.object.required?(key) %> <% else %> <%= f.input key, input_html: { value: f.object.model[key].first, data: { provide: 'datepicker', 'date-force-parse': 'false', 'date-autoclose': 'true' } }, required: f.object.required?(key) %> diff --git a/app/views/records/edit_fields/_date_submitted.html.erb b/app/views/records/edit_fields/_date_submitted.html.erb index 738c00ee..968648d2 100644 --- a/app/views/records/edit_fields/_date_submitted.html.erb +++ b/app/views/records/edit_fields/_date_submitted.html.erb @@ -1,6 +1,6 @@ <% # use date picker %> -<% if f.object.class.multiple? key %> +<% f.object.try(:multiple?, key) || f.object.class.try(:multiple?, key) %> <%= f.input key, as: :multi_value, input_html: { data: { provide: 'datepicker', 'date-force-parse': 'false', 'date-autoclose': 'true' } }, required: f.object.required?(key) %> <% else %> <%= f.input key, input_html: { value: f.object.model[key].first, data: { provide: 'datepicker', 'date-force-parse': 'false', 'date-autoclose': 'true' } }, required: f.object.required?(key) %> diff --git a/app/views/records/edit_fields/_date_updated.html.erb b/app/views/records/edit_fields/_date_updated.html.erb index 738c00ee..968648d2 100644 --- a/app/views/records/edit_fields/_date_updated.html.erb +++ b/app/views/records/edit_fields/_date_updated.html.erb @@ -1,6 +1,6 @@ <% # use date picker %> -<% if f.object.class.multiple? key %> +<% f.object.try(:multiple?, key) || f.object.class.try(:multiple?, key) %> <%= f.input key, as: :multi_value, input_html: { data: { provide: 'datepicker', 'date-force-parse': 'false', 'date-autoclose': 'true' } }, required: f.object.required?(key) %> <% else %> <%= f.input key, input_html: { value: f.object.model[key].first, data: { provide: 'datepicker', 'date-force-parse': 'false', 'date-autoclose': 'true' } }, required: f.object.required?(key) %> diff --git a/app/views/records/edit_fields/_date_valid.html.erb b/app/views/records/edit_fields/_date_valid.html.erb index 738c00ee..968648d2 100644 --- a/app/views/records/edit_fields/_date_valid.html.erb +++ b/app/views/records/edit_fields/_date_valid.html.erb @@ -1,6 +1,6 @@ <% # use date picker %> -<% if f.object.class.multiple? key %> +<% f.object.try(:multiple?, key) || f.object.class.try(:multiple?, key) %> <%= f.input key, as: :multi_value, input_html: { data: { provide: 'datepicker', 'date-force-parse': 'false', 'date-autoclose': 'true' } }, required: f.object.required?(key) %> <% else %> <%= f.input key, input_html: { value: f.object.model[key].first, data: { provide: 'datepicker', 'date-force-parse': 'false', 'date-autoclose': 'true' } }, required: f.object.required?(key) %> diff --git a/app/views/records/edit_fields/_default.html.erb b/app/views/records/edit_fields/_default.html.erb index ebc5b4d0..52a69b54 100644 --- a/app/views/records/edit_fields/_default.html.erb +++ b/app/views/records/edit_fields/_default.html.erb @@ -1,5 +1,5 @@ <% # the hyrax version of this file messes singular field display %> -<% if f.object.class.multiple?(key) %> +<% f.object.try(:multiple?, key) || f.object.class.try(:multiple?, key) %> <%= f.input key, as: :multi_value, input_html: { class: 'form-control' }, required: f.object.required?(key) %> <% else %> <% value = f.object.model[key] %> diff --git a/app/views/records/edit_fields/_end_date.html.erb b/app/views/records/edit_fields/_end_date.html.erb index 738c00ee..968648d2 100644 --- a/app/views/records/edit_fields/_end_date.html.erb +++ b/app/views/records/edit_fields/_end_date.html.erb @@ -1,6 +1,6 @@ <% # use date picker %> -<% if f.object.class.multiple? key %> +<% f.object.try(:multiple?, key) || f.object.class.try(:multiple?, key) %> <%= f.input key, as: :multi_value, input_html: { data: { provide: 'datepicker', 'date-force-parse': 'false', 'date-autoclose': 'true' } }, required: f.object.required?(key) %> <% else %> <%= f.input key, input_html: { value: f.object.model[key].first, data: { provide: 'datepicker', 'date-force-parse': 'false', 'date-autoclose': 'true' } }, required: f.object.required?(key) %> diff --git a/app/views/records/edit_fields/_event_date.html.erb b/app/views/records/edit_fields/_event_date.html.erb index 738c00ee..968648d2 100644 --- a/app/views/records/edit_fields/_event_date.html.erb +++ b/app/views/records/edit_fields/_event_date.html.erb @@ -1,6 +1,6 @@ <% # use date picker %> -<% if f.object.class.multiple? key %> +<% f.object.try(:multiple?, key) || f.object.class.try(:multiple?, key) %> <%= f.input key, as: :multi_value, input_html: { data: { provide: 'datepicker', 'date-force-parse': 'false', 'date-autoclose': 'true' } }, required: f.object.required?(key) %> <% else %> <%= f.input key, input_html: { value: f.object.model[key].first, data: { provide: 'datepicker', 'date-force-parse': 'false', 'date-autoclose': 'true' } }, required: f.object.required?(key) %> diff --git a/app/views/records/edit_fields/_start_date.html.erb b/app/views/records/edit_fields/_start_date.html.erb index 738c00ee..968648d2 100644 --- a/app/views/records/edit_fields/_start_date.html.erb +++ b/app/views/records/edit_fields/_start_date.html.erb @@ -1,6 +1,6 @@ <% # use date picker %> -<% if f.object.class.multiple? key %> +<% f.object.try(:multiple?, key) || f.object.class.try(:multiple?, key) %> <%= f.input key, as: :multi_value, input_html: { data: { provide: 'datepicker', 'date-force-parse': 'false', 'date-autoclose': 'true' } }, required: f.object.required?(key) %> <% else %> <%= f.input key, input_html: { value: f.object.model[key].first, data: { provide: 'datepicker', 'date-force-parse': 'false', 'date-autoclose': 'true' } }, required: f.object.required?(key) %>