Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plots don't obey limits #1069

Open
jgassert opened this issue Jan 15, 2025 · 3 comments
Open

plots don't obey limits #1069

jgassert opened this issue Jan 15, 2025 · 3 comments

Comments

@jgassert
Copy link

After running

m_fldaCDM.migrad()
m_fldaCDM.hesse() 

in a Jupyter notebook, the plots of data and fit are automatically displayed, but the fitted line is only plotted over the first and last datapoint. In an unsorted array/list, this gives unexpected plots, not starting from the beginning. A simple addition of min/max calls when plotting would solve this issue.

@HDembinski
Copy link
Member

Can you upload an example image? I cannot quite picture what you mean. Ideally, if you could provide a short reproducer so that I can see what the issue is, I might be able to fix it. Or if you already know how to fix it, please submit a PR.

@jgassert
Copy link
Author

jgassert commented Feb 22, 2025

After fitting a function where the x-values are not ordered, the line plot is not covering the whole range. See below image. The x-value array/list here starts at 0.43 and ends (last entry) is 0.83, while the whole array/list contains smaller and larger values.

Image

@HDembinski
Copy link
Member

Ah, I get it now, that should be easy to fix. Thanks for reporting, I will work on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants