Add a test in Dockerfile directly to check varnish version #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phracek
force-pushed
the
test_version_id_dockerfile
branch
from
f474814 to
82ee962
Compare
|
[test] |
zmiklank
reviewed
Oct 26, 2023
Use $VARNISH_VERSION for proper detection Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
phracek
force-pushed
the
test_version_id_dockerfile
branch
from
82ee962 to
7c6c6d9
Compare
|
[test] |
|
LGTM, didn't spot any issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a test in Dockerfile directly to check varnish version
Otherwise when a wrong stream is installed, it's only found by scl test, which is too late in the process.