-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG][Accessibility]: Date Picker Component #103
Comments
Thank you Lewis. Fixes for these should go into the next DS release. |
Just to add to this, |
Just to add to this, I couldn't get keyboard navigation to work in Safari. |
Hi @matthewford, can you be more specific? E.g. what keyboard interactions are failing, what version of Safari are you using? |
I'm trying to open the calendar widget - which works in Chrome but doesn't work in Safari 17.6 (a college also reported it is not working on their Safari, which might have been a different version). |
Ah, I see -- that's actually just default Safari behaviour. Tabbing in Safari does not tab through every interactive element as you might expect from other browsers, but only tabs through text fields and pop-up menus. You can press option-tab to tab into other types of element, or you can set an option in Safari preferences to make the tab key behave similarly to how it works in other browsers (Preferences -> Advanced -> Press Tab to highlight each option on a web page). Since that is something that is controlled by a user's preferences it is not appropriate for us to try to force that behaviour at all times. |
Description of the issue
After an accessibility audit on the Social Security Scotland Digital Portal, a few issues were raised with the Date Picker component supplied by the Design System.
Screen reader users aren't informed when the calendar is navigated.
When using the next/previous month and year buttons, user is not informed of the new month/year being displayed.
It was recommended that the
.ds_datepicker__dialog__title
element be givenaria-live="polite"
.aria-selected="true"
is not supported on<button>
elementsThe currently selected month has the
aria-selected="true"
attribute, however this attribute is not actually supported on<button>
elements. This means that screen reader users are not informed when they are on the currently selected date.The WAI Date Picker Dialog uses a
<table role="grid">
which additionally marks each<td>
as being interact-able, and the<td>
here supportsaria-selected
.Alternatively
aria-pressed
may be more appropriate to useCurrent date does not use
aria-current
The current date is visually shown to clients, however this isn't highlighted to assistive technologies. This should have the
aria-current="date"
attribute, which would inform screen reader users that it is the current date.The text was updated successfully, but these errors were encountered: