Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate complex class names #34

Open
gaku-sei opened this issue Aug 5, 2021 · 0 comments
Open

Investigate complex class names #34

gaku-sei opened this issue Aug 5, 2021 · 0 comments
Labels
command:validate Related to the `pyaco validate` command

Comments

@gaku-sei
Copy link
Contributor

gaku-sei commented Aug 5, 2021

So far, in order to keep it fast, we don't parse files provided to the style-validate binary. It works well with HTML files and some other files we're using in other projects but parsing complex class names like className={isDisabled ? "disabled" : "active"} is a legitimate use case.

Let's first try to use the current engine with regexes, and if it doesn't work we'll have to provide a more powerful parser.

Also, we could use duktape or v8 in order to support scripting in javascript, that would keep the codebase as is, but it might come with a big impact on performances, especially on large projects with +5.000 files.

@gaku-sei gaku-sei added the command:validate Related to the `pyaco validate` command label Aug 5, 2021
@gaku-sei gaku-sei changed the title Support complex scenario Support complex class names Aug 5, 2021
@gaku-sei gaku-sei changed the title Support complex class names Investigate complex class names Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
command:validate Related to the `pyaco validate` command
Projects
None yet
Development

No branches or pull requests

1 participant