Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies created via DynamicDeps are not counted in stats #213

Open
kmike opened this issue Dec 16, 2024 · 0 comments
Open

Dependencies created via DynamicDeps are not counted in stats #213

kmike opened this issue Dec 16, 2024 · 0 comments

Comments

@kmike
Copy link
Member

kmike commented Dec 16, 2024

It seems DynamicDeps is counted as a single dependency; what's inside doesn't appear in stats. We should count these dependencies in stats as well.

It's a question if they need to add to the same stat as current poet/injector stats, or if they should go with another prefix.
For me it sounds better to use the same prefix, because there shouldn't be a difference between using DynamicDeps and hardcoding a dependency as a callback argument.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant