From c1e4cfbea1e9865ee18517012c0b1c8fd5596686 Mon Sep 17 00:00:00 2001 From: Supratik Das <30755453+supra08@users.noreply.github.com> Date: Wed, 5 Aug 2020 05:31:41 +0530 Subject: [PATCH] fix(1079): Remove unnecessary autoDeployKeyGenerationEnabled function (#168) * feat(scm-github): Add key pair generation method and push pub key to scm * feat(scm-github): Add key pair generation method and push pub key to scm * feat(): add accessor function for checking autoDeployKeyGeneration * feat(scm-github): add tests for addDeployKey and checkAutoDeployKeyGeneration * refactor(): change function names and localize constants * refactor(): use object destructing in config and use maps --- index.js | 9 --------- test/index.test.js | 8 -------- 2 files changed, 17 deletions(-) diff --git a/index.js b/index.js index 292bd56..36b32d8 100644 --- a/index.js +++ b/index.js @@ -372,15 +372,6 @@ class GithubScm extends Scm { } } - /** - * Returns whether auto deploy key generation is enabled or not - * @async _autoDeployKeyGenerationEnabled - * @return {Boolean} Resolves to the private key string - */ - async _autoDeployKeyGenerationEnabled() { - return this.config.autoDeployKeyGeneration; - } - /** * Look up a webhook from a repo * @async _findWebhook diff --git a/test/index.test.js b/test/index.test.js index 8a3c89a..3f63a8f 100644 --- a/test/index.test.js +++ b/test/index.test.js @@ -1954,14 +1954,6 @@ jobs: }); }); - describe('autoDeployKeyGenerationEnabled', () => { - it('returns a boolean check', () => - scm.autoDeployKeyGenerationEnabled().then((check) => { - assert.isBoolean(check); - }) - ); - }); - describe('getBellConfiguration', () => { it('returns a default configuration', () => ( scm.getBellConfiguration().then((config) => {