fix: upload large payload for cache (#61)

d2lam · web-flow · commit b509838abefa · 2018-10-17T17:13:32.000-07:00
diff --git a/plugins/builds.js b/plugins/builds.js
@@ -105,8 +105,11 @@ exports.plugin = {
                     }
                 });
 
-                // For text/plain payload, upload it as Buffer
-                if (contents.h['content-type'] === 'text/plain') {
+                // For text/plain payload or application/zip, upload it as Buffer
+                // Otherwise, catbox-s3 will try to JSON.stringify (https://github.com/fhemberger/catbox-s3/blob/master/lib/index.js#L236)
+                // and might create issue on large payload
+                if (contents.h['content-type'] === 'text/plain' ||
+                    contents.h['content-type'] === 'application/zip') {
                     value = contents.c;
                 }
 

Original file line number	Diff line number	Diff line change
`@@ -105,8 +105,11 @@ exports.plugin = {`
`105`	`105`	`}`
`106`	`106`	`});`
`107`	`107`
`108`		`- // For text/plain payload, upload it as Buffer`
`109`		`- if (contents.h['content-type'] === 'text/plain') {`
	`108`	`+ // For text/plain payload or application/zip, upload it as Buffer`
	`109`	`+ // Otherwise, catbox-s3 will try to JSON.stringify (https://github.com/fhemberger/catbox-s3/blob/master/lib/index.js#L236)`
	`110`	`+ // and might create issue on large payload`
	`111`	`+ if (contents.h['content-type'] === 'text/plain' \|\|`
	`112`	`+ contents.h['content-type'] === 'application/zip') {`
`110`	`113`	`value = contents.c;`
`111`	`114`	`}`
`112`	`115`