From bf63c29cbb4898c8f2ac4ca2a8c565089ba252a7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?P=C3=A9ter=20Garamv=C3=B6lgyi?= Date: Tue, 2 Jul 2024 16:21:24 +0200 Subject: [PATCH] fix: fix incorrect JSON encoding in ScrollBadgePowerRank example (#47) * fix: fix incorrect JSON encoding in ScrollBadgePowerRank example * use encodePacked for token name --- src/badge/examples/ScrollBadgePowerRank.sol | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/badge/examples/ScrollBadgePowerRank.sol b/src/badge/examples/ScrollBadgePowerRank.sol index 53cf075..07a6523 100644 --- a/src/badge/examples/ScrollBadgePowerRank.sol +++ b/src/badge/examples/ScrollBadgePowerRank.sol @@ -78,11 +78,11 @@ contract ScrollBadgePowerRank is /// @inheritdoc ScrollBadge function badgeTokenURI(bytes32 uid) public view override returns (string memory) { uint256 rank = badgeRank[uid]; - string memory name = string(abi.encode("Scroll Power Rank #", Strings.toString(rank))); + string memory name = string(abi.encodePacked("Scroll Power Rank #", Strings.toString(rank))); string memory description = "Scroll Power Rank Badge"; string memory image = ""; // IPFS, HTTP, or data URL string memory tokenUriJson = Base64.encode( - abi.encodePacked('{"name":"', name, '", "description":"', description, ', "image": "', image, '"}') + abi.encodePacked('{"name":"', name, '", "description":"', description, '", "image": "', image, '"}') ); return string(abi.encodePacked("data:application/json;base64,", tokenUriJson)); }