Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll EvmExecutor implementation #5

Open
Tracked by #16
frisitano opened this issue Oct 1, 2024 · 2 comments
Open
Tracked by #16

Scroll EvmExecutor implementation #5

frisitano opened this issue Oct 1, 2024 · 2 comments
Milestone

Comments

@frisitano
Copy link
Collaborator

Describe the feature

Overview

To execute blocks using scroll-revm we must implement an EvmExecutor (and associated assets) that wraps scroll-revm and executes blocks. An example of optimism specific Executor assets can be found here. Logic from the stateless-block-verifier can be used as a guide for the block execution logic.

Additional context

No response

@frisitano frisitano added this to the Milestone 1 milestone Oct 1, 2024
@Thegaram
Copy link

Thegaram commented Oct 3, 2024

It seems there is no EvmExecutor trait yet. Do you mean we should define a ScrollEvmExecutor<EvmConfig> that implements execute_state_transitions, as well as ScrollBlockExecutor etc, following the Eth and Op examples?

@frisitano
Copy link
Collaborator Author

Sorry I should have been explicit when referring to what we need to implement. Here is an example of the OpEvmExecutor. We would also need to implement associated types such as OpBlockExecutor , OpBatchExecutor, OpExecutorProvider and implement the required traits on these types, i.e. Executor, BatchExecutor and BlockExecutorProvider respectively.

@frisitano frisitano mentioned this issue Oct 8, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

2 participants