Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature reqeust: add data_hash to batch API #164

Open
lispc opened this issue Mar 30, 2024 · 0 comments
Open

feature reqeust: add data_hash to batch API #164

lispc opened this issue Mar 30, 2024 · 0 comments

Comments

@lispc
Copy link

lispc commented Mar 30, 2024

why:

batch pi_hash is calculated in rust/golang/solidity. In case there is any inconsistency, having this field inside API can help debugging. For example, currently in circuit side, we fetch fetch all blocks inside a batch and proving the batch, but cannot constrain the batch pi == batch pi calculated by other components(coordinator, contracts). So exposing data_hash is useful.

@lispc lispc changed the title feature reqeust: add pi_hash to batch API feature reqeust: add data_hash to batch API Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant