From 529692884a32762eec2aada7739709ab81d1e24e Mon Sep 17 00:00:00 2001 From: HAOYUatHZ Date: Thu, 24 Oct 2024 10:32:23 +0800 Subject: [PATCH] feat(coordinator): add version check for sdk provers --- common/version/prover_version.go | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/common/version/prover_version.go b/common/version/prover_version.go index 6b49164364..2b7a52f3b3 100644 --- a/common/version/prover_version.go +++ b/common/version/prover_version.go @@ -9,6 +9,10 @@ import ( // CheckScrollProverVersion check the "scroll-prover" version, if it's different from the local one, return false func CheckScrollProverVersion(proverVersion string) bool { + if strings.HasPrefix(proverVersion, "sdk") { + return CheckProverSDKVersion(proverVersion) + } + // note the version is in fact in the format of "tag-commit-scroll_prover-halo2", // so split-by-'-' length should be 4 remote := strings.Split(proverVersion, "-") @@ -23,8 +27,18 @@ func CheckScrollProverVersion(proverVersion string) bool { return remote[2] == local[2] } +// CheckProverSDKVersion check prover sdk version, it simply returns true for now, +// and more checks will be added as we evolve. +func CheckProverSDKVersion(proverVersion string) bool { + return true +} + // CheckScrollRepoVersion checks if the proverVersion is at least the minimum required version. func CheckScrollRepoVersion(proverVersion, minVersion string) bool { + if strings.HasPrefix(proverVersion, "sdk") { + return CheckProverSDKWithMinVersion(proverVersion, minVersion) + } + c, err := semver.NewConstraint(">= " + minVersion + "-0") if err != nil { log.Error("failed to initialize constraint", "minVersion", minVersion, "error", err) @@ -39,3 +53,9 @@ func CheckScrollRepoVersion(proverVersion, minVersion string) bool { return c.Check(v) } + +// CheckProverSDKWithMinVersion check prover sdk version is at least the minimum required version, it simply returns true for now, +// and more checks will be added as we evolve. +func CheckProverSDKWithMinVersion(proverVersion string, minVersion string) bool { + return true +}