Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new evaluation indicators #35

Open
coderlsb opened this issue Sep 12, 2024 · 5 comments
Open

Add new evaluation indicators #35

coderlsb opened this issue Sep 12, 2024 · 5 comments

Comments

@coderlsb
Copy link

How to add the evaluation indicators you need when evaluating or training the model

@SunnyHaze
Copy link
Contributor

SunnyHaze commented Sep 13, 2024

Hi! Thanks for your attention to our work.

Sorry that we have identified an existing bug that AUC may not incorporate properly. #36 We will solve it today.

If this issue is solved, you may update the IMDL-BenCo with pip install. Then copy a train.py and change this line to the
corresponding evaluator you expected.

PixelF1(threshold=0.5, mode="origin"),

@SunnyHaze
Copy link
Contributor

SunnyHaze commented Sep 13, 2024

solved with PR #38

You can follow the instructions to change the ideal evaluators with the name mentioned here.

https://github.com/scu-zjz/IMDLBenCo/blob/main/IMDLBenCo/evaluation/__init__.py


If you want to define new extactors, please reload the AbstractEvaluator with the following class.

https://github.com/scu-zjz/IMDLBenCo/blob/main/IMDLBenCo/evaluation/abstract_class.py

@SunnyHaze
Copy link
Contributor

This guidance will be added to the documentation soon. Sincerely thanks for pointing out the issue.

@coderlsb
Copy link
Author

Thank you for your reply! I introduced PixelAUC in tester.py through from IMDLBenCo.evaluation.AUC import PixelAUC, and added the following code to the test_one_epoch function
9dffab7d2b4702d02593d92f24c36051
I test the trained model,Are the following results reliable?
image

@SunnyHaze
Copy link
Contributor

SunnyHaze commented Sep 14, 2024

Hi, thanks for your feedback.

I introduced PixelAUC in tester.py through IMDLBenCo.evaluation.AUC import PixelAUC
If you have updated the IMDL-BenCo with pip to the latest version, there could be a shorter way to import the PixelAUC class.

from IMDLBenCo.evaluation import PixelAUC

and added the following code to the test_one_epoch function

I believe the best place to insert the evaluator is here, but the test_one_epoch function. Please check it.

evaluator_list = [
PixelF1(threshold=0.5, mode="origin"),
# ImageF1(threshold=0.5)
]

For reliability, we have tested all evaluator classes with test functions like this:

def test_origin_image_f1():

Honestly, if you are writing research papers, I recommend you to do a simple double-check with standard metrics in sklearn on your test cases for the best reliability. Since this project is in early development, although we do our best to maintain the details reliably, we may have negligence in corner cases. Sorry for the inconvenience caused by this matter, but your rigor contributes to the entire academic community. Also, feel free to share the corresponding logs and metrics to help us to locate the issue. We will give our attention as soon as possible.

Thanks again for trying out IMDL-BenCo. If you have further issues or questions, please feel free to discuss them here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants