Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run a check for if the directory is too large #1

Open
sdras opened this issue Sep 9, 2018 · 2 comments
Open

Run a check for if the directory is too large #1

sdras opened this issue Sep 9, 2018 · 2 comments
Labels
good first issue Good for newcomers

Comments

@sdras
Copy link
Owner

sdras commented Sep 9, 2018

If someone mistakenly points to root or some gigantic directory they didn't mean to, it will just get clogged for a while. This needs a check for how large the file is- and maybe a loader too? I'm interested to hear people's opinions on this before I implement it for what the expected behavior should be.

@sdras sdras added the good first issue Good for newcomers label Sep 10, 2018
@insuusvenerati
Copy link

Maybe check to see if the chosen directory is outside the PWD? Sort how you docker errors when you try to set the build context outside the pwd.

That way you don’t accidentally set ../

@ryanraposo
Copy link

Just happened to me testing it out, ran it in my repo folder. How do you feel about a "[doing x with path], proceed?"-style confirmation? Maybe included in that is a one layer deep directory/file list?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants