Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tmpmail 1.2.3 (new formula) #181399

Merged
merged 2 commits into from
Aug 18, 2024
Merged

tmpmail 1.2.3 (new formula) #181399

merged 2 commits into from
Aug 18, 2024

Conversation

chenrui333
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

fixes sdushantha/tmpmail#55
package inclusions, https://repology.org/project/tmpmail/versions

@github-actions github-actions bot added new formula PR adds a new formula to Homebrew/homebrew-core linux-only Formula depends on Linux labels Aug 16, 2024
@Homebrew Homebrew deleted a comment from github-actions bot Aug 16, 2024
@github-actions github-actions bot removed the linux-only Formula depends on Linux label Aug 16, 2024
@github-actions github-actions bot added automerge-skip `brew pr-automerge` will skip this pull request autobump labels Aug 16, 2024
Signed-off-by: Rui Chen <rui@chenrui.dev>

autobump: add tmpmail

Signed-off-by: Rui Chen <rui@chenrui.dev>
Copy link

@lodenrogue lodenrogue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@vszakats
Copy link
Contributor

vszakats commented Aug 16, 2024

xclip wasn't working for me on macOS, and it also requires a bunch of heavy dependencies, like XQuartz. This patch fixes it to use the OS-native pbcopy:

--- tmpmail-ori
+++ tmpmail
@@ -13,7 +13,7 @@
 
 # The default command that will be used to copy the email address to
 # the user's clipboard when running 'tmpmail --copy'
-copy_to_clipboard_cmd="xclip -selection c"
+copy_to_clipboard_cmd="pbcopy"
 
 # If the value is set to 'true' tmpmail will convert the HTML email
 # to raw text and send that to stdout

@lodenrogue
Copy link

pbcopy works on Linux?

@vszakats
Copy link
Contributor

No, this is for macOS only.

@vszakats
Copy link
Contributor

For portability, something like this can work:

if command -v pbcopy >/dev/null 2>&1; then
  copy_to_clipboard_cmd="pbcopy"
else
  copy_to_clipboard_cmd="xclip -selection c"
fi

or:

case "$(uname)" in
  Darwin*) copy_to_clipboard_cmd="pbcopy";;
  *)       copy_to_clipboard_cmd="xclip -selection c";;
esac

@chenrui333
Copy link
Member Author

xclip wasn't working for me on macOS, and it also requires a bunch of heavy dependencies, like XQuartz. This patch fixes it to use the OS-native pbcopy:

--- tmpmail-ori
+++ tmpmail
@@ -13,7 +13,7 @@
 
 # The default command that will be used to copy the email address to
 # the user's clipboard when running 'tmpmail --copy'
-copy_to_clipboard_cmd="xclip -selection c"
+copy_to_clipboard_cmd="pbcopy"
 
 # If the value is set to 'true' tmpmail will convert the HTML email
 # to raw text and send that to stdout

can you submit that to the upstream?

also if just XQuartz concern, I think it is probably okay? as xclip use the same dep tree for both linux and macOS from homebrew perspective

@vszakats
Copy link
Contributor

Maybe it's just me but xclip didn't work (or worked oddly?) though the machine already had XQuartz. Using the native tool is just overall nicer.

I prefer to leave the upstreaming to someone else, too much other open source stuff to do at the moment.
(feel free take my snippets as-is)

@chenrui333 chenrui333 removed the automerge-skip `brew pr-automerge` will skip this pull request label Aug 18, 2024
@chenrui333
Copy link
Member Author

Maybe it's just me but xclip didn't work (or worked oddly?) though the machine already had XQuartz. Using the native tool is just overall nicer.

I prefer to leave the upstreaming to someone else, too much other open source stuff to do at the moment. (feel free take my snippets as-is)

sounds good, I am gonna merge it for now, we can always followup to improve it for everyone. Thanks for the input though! 👍

Copy link
Contributor

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Aug 18, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Aug 18, 2024
Merged via the queue into master with commit e772ffc Aug 18, 2024
15 checks passed
@BrewTestBot BrewTestBot deleted the tmpmail branch August 18, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autobump CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. new formula PR adds a new formula to Homebrew/homebrew-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tmpmail on Homebrew!
5 participants