-
-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tmpmail 1.2.3 (new formula) #181399
tmpmail 1.2.3 (new formula) #181399
Conversation
Signed-off-by: Rui Chen <rui@chenrui.dev> autobump: add tmpmail Signed-off-by: Rui Chen <rui@chenrui.dev>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
--- tmpmail-ori
+++ tmpmail
@@ -13,7 +13,7 @@
# The default command that will be used to copy the email address to
# the user's clipboard when running 'tmpmail --copy'
-copy_to_clipboard_cmd="xclip -selection c"
+copy_to_clipboard_cmd="pbcopy"
# If the value is set to 'true' tmpmail will convert the HTML email
# to raw text and send that to stdout
|
pbcopy works on Linux? |
No, this is for macOS only. |
For portability, something like this can work: if command -v pbcopy >/dev/null 2>&1; then
copy_to_clipboard_cmd="pbcopy"
else
copy_to_clipboard_cmd="xclip -selection c"
fi or: case "$(uname)" in
Darwin*) copy_to_clipboard_cmd="pbcopy";;
*) copy_to_clipboard_cmd="xclip -selection c";;
esac |
can you submit that to the upstream? also if just XQuartz concern, I think it is probably okay? as |
Maybe it's just me but I prefer to leave the upstreaming to someone else, too much other open source stuff to do at the moment. |
sounds good, I am gonna merge it for now, we can always followup to improve it for everyone. Thanks for the input though! 👍 |
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?fixes sdushantha/tmpmail#55
package inclusions, https://repology.org/project/tmpmail/versions