Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show results gh poi protect command #102

Open
seachicken opened this issue Apr 29, 2023 · 1 comment
Open

Show results gh poi protect command #102

seachicken opened this issue Apr 29, 2023 · 1 comment

Comments

@seachicken
Copy link
Owner

Description
Since the result is not displayed even if the gh poi protect <branchname>... command succeeds, the user feels anxiety about whether the command succeeded or not, so the result of success or failure should be displayed.

Additional context

@spenserblack
Copy link

Personally, knowing that gh poi protect uses the git config to save protected branches, I would open .git/config to ensure that the branch is protected. So a generic message like "Updated git config" might be good enough.

However, I see you use the setting branch.<branch-name>.gh-poi-protected. If, instead of using an individual setting for each protected branch, you used a list setting, it would be easier for the user to view all protected branches. For example:

$ git config --add gh-poi.protected main
$ git config --add gh-poi.protected dev
$ git config --add gh-poi.protected my-personal-branch
$ git config --get-all gh-poi.protected
main
dev
my-personal-branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants