Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix golang ci lint error #2311

Merged
merged 1 commit into from
Oct 25, 2023
Merged

chore: fix golang ci lint error #2311

merged 1 commit into from
Oct 25, 2023

Conversation

starnop
Copy link
Collaborator

@starnop starnop commented Oct 25, 2023

Describe what this PR does / why we need it

  1. ignore has no field or method error from typecheck linter
  2. replace deprecated linter to suggested replaced linter
  3. fix gosec error

Does this pull request fix one issue?

Describe how you did it

Describe how to verify it

Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Files Coverage Δ
utils/archive/compress.go 16.31% <0.00%> (ø)

... and 164 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@github-actions github-actions bot added the e2e-test it needs to run e2e test label Oct 25, 2023
Signed-off-by: yuxing.lyx <yuxing.lyx@alibaba-inc.com>
Copy link
Collaborator

@VinceCui VinceCui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VinceCui VinceCui merged commit ec4a2c7 into sealerio:main Oct 25, 2023
11 checks passed
sjcsjc123 pushed a commit to sjcsjc123/sealer that referenced this pull request Oct 26, 2023
Signed-off-by: yuxing.lyx <yuxing.lyx@alibaba-inc.com>
Signed-off-by: sjcsjc123 <1401189096@qq.com>
sjcsjc123 pushed a commit to sjcsjc123/sealer that referenced this pull request Oct 29, 2023
Signed-off-by: yuxing.lyx <yuxing.lyx@alibaba-inc.com>
Signed-off-by: sjcsjc123 <1401189096@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e-test it needs to run e2e test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants