Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumped the version of golangci-lint #2312

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Conversation

dynos01
Copy link
Contributor

@dynos01 dynos01 commented Oct 26, 2023

Describe what this PR does / why we need it

  • Bumped the version of golangci-lint to 1.44.0 (this version uses far less memory than previous versions)
  • Fixed one line of error message that cannot pass new lints

Does this pull request fix one issue?

Describe how you did it

Describe how to verify it

Special notes for reviews

Signed-off-by: Yinuo Deng <i@dyn.im>
@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Files Coverage Δ
pkg/imageengine/buildah/inspect.go 38.14% <0.00%> (ø)

... and 164 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

Copy link
Collaborator

@VinceCui VinceCui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VinceCui VinceCui merged commit 2366836 into sealerio:main Oct 26, 2023
11 checks passed
sjcsjc123 pushed a commit to sjcsjc123/sealer that referenced this pull request Oct 26, 2023
Signed-off-by: Yinuo Deng <i@dyn.im>
Signed-off-by: sjcsjc123 <1401189096@qq.com>
@dynos01 dynos01 deleted the ci_bump branch October 27, 2023 02:45
sjcsjc123 pushed a commit to sjcsjc123/sealer that referenced this pull request Oct 29, 2023
Signed-off-by: Yinuo Deng <i@dyn.im>
Signed-off-by: sjcsjc123 <1401189096@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants