fix multi-document yaml reading errors #2322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2322 +/- ##
==========================================
- Coverage 20.50% 13.43% -7.08%
==========================================
Files 96 260 +164
Lines 9129 22656 +13527
==========================================
+ Hits 1872 3043 +1171
- Misses 7002 19202 +12200
- Partials 255 411 +156
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
maxwell-can-not-fly
force-pushed
the
fix-value-yaml-reading
branch
from
5d4f76a
to
4d70681
Compare
Signed-off-by: Maxwell <144507225+maxwell-can-not-fly@users.noreply.github.com>
maxwell-can-not-fly
force-pushed
the
fix-value-yaml-reading
branch
from
4d70681
to
8d45ca5
Compare
jjkobe
approved these changes
Apr 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
this fixes a multi-document yaml reading issue, which may break application install
Does this pull request fix one issue?
Fixes #2299
Describe how you did it
use yaml decoder for multi-document yaml reading
Describe how to verify it
this can be reproduced by unit tests, a unit test file is added for verification
Special notes for reviews