fixed: enable --skip-tls-verify during the build phase #2346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
test
ImageBuilding
Signed-off-by: teacher2018 <worldwideteacher@163.com>
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files@@ Coverage Diff @@
## main #2346 +/- ##
==========================================
- Coverage 20.50% 1.27% -19.24%
==========================================
Files 96 165 +69
Lines 9128 13846 +4718
==========================================
- Hits 1872 176 -1696
- Misses 7001 13654 +6653
+ Partials 255 16 -239
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
Command "sealer build", kubefileparse.imageEngine not support http shema in pull phase automatically. so we can do something to expand functionality.
Does this pull request fix one issue?
Fixes #2345
Describe how you did it
Add --skip-tls-verify option to "sealer build" command, then kubefileparse.pull() can get it
Describe how to verify it
Reference issue #2345 to reproduce , without http schema error output
Special notes for reviews