Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor redirects to use tower-http #2576

Open
seanmonstar opened this issue Mar 3, 2025 · 0 comments
Open

Refactor redirects to use tower-http #2576

seanmonstar opened this issue Mar 3, 2025 · 0 comments
Labels
C-refactor Category: refactor. This would improve the clarity of internal code. E-medium Effort: medium. A moderate amount of work. E-pr-welcome The feature is welcome to be added, instruction should be found in the issue.

Comments

@seanmonstar
Copy link
Owner

reqwest supports defining redirect policies, and provides a few common ones. That support was later ported to tower_http::follow_redirect. To reduce duplication, and to make sure the tower-http code has all the improvements reqwest gets, we should just make reqwest depend on the one from tower-http.

Note: the public APIs are a little different. To prevent a breaking change, we should make the refactor simply internal.

@seanmonstar seanmonstar added C-refactor Category: refactor. This would improve the clarity of internal code. E-medium Effort: medium. A moderate amount of work. E-pr-welcome The feature is welcome to be added, instruction should be found in the issue. labels Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-refactor Category: refactor. This would improve the clarity of internal code. E-medium Effort: medium. A moderate amount of work. E-pr-welcome The feature is welcome to be added, instruction should be found in the issue.
Projects
Status: No status
Development

No branches or pull requests

1 participant