plans: use i18n to format the dates on the plan edit dialog (#134)

Author: wfleischer

lib/src/localization/app_en.arb

@@ -100,7 +100,8 @@
     "description": "The with target date status subtitle on the plan edit page",
     "placeholders": {
       "targetDate": {
-        "type": "String"
+        "type": "DateTime",
+        "format": "yMd"
       },
       "direction": {
         "type": "String"
@@ -119,7 +120,8 @@
     "description": "The reset target date subtitle on the plan edit page",
     "placeholders": {
       "targetDate": {
-        "type": "String"
+        "type": "DateTime",
+        "format": "yMd"
       }
     }
   },

lib/src/plans/presentations/plan_edit_dialog.dart

@@ -57,8 +57,10 @@ class PlanEditDialog extends ConsumerWidget {
           const SizedBox(height: 20),
           PlanLanguageTile(planId),
           PlanWithTargetDateTile(planId),
-          if (plan.withTargetDate && plan.targetDate != adjustedTargetDate)
-            PlanResetTargetDateTile(planId),
+          if (plan.withTargetDate &&
+              adjustedTargetDate != null &&
+              plan.targetDate != adjustedTargetDate)
+            PlanResetTargetDateTile(planId, adjustedTargetDate),
           PlanShowEventsTile(planId),
           PlanShowLocationsTile(planId),
           if (!isNewPlan)

lib/src/plans/presentations/plan_reset_target_date_tile.dart

@@ -4,26 +4,23 @@ import 'package:flutter_riverpod/flutter_riverpod.dart';
 import 'package:nwt_reading/src/plans/stories/plan_edit_story.dart';
 
 class PlanResetTargetDateTile extends ConsumerWidget {
-  const PlanResetTargetDateTile(this.planId, {super.key});
+  const PlanResetTargetDateTile(this.planId, this.adjustedTargetDate,
+      {super.key});
 
   final String? planId;
+  final DateTime adjustedTargetDate;
 
   @override
   Widget build(BuildContext context, WidgetRef ref) {
     ref.watch(planEditProviderFamily(planId));
     final planEdit = ref.read(planEditProviderFamily(planId).notifier);
-    final adjustedTargetDate = planEdit.calcTargetDate();
-    final formattedAdjustedTargetDate = adjustedTargetDate != null
-        ? MaterialLocalizations.of(context)
-            .formatCompactDate(adjustedTargetDate)
-        : '';
 
     return ListTile(
       key: const Key('reset-target-date'),
       title:
           Text(AppLocalizations.of(context).planEditPageResetTargetDateTitle),
       subtitle: Text(AppLocalizations.of(context)
-          .planEditPageResetTargetDateSubtitle(formattedAdjustedTargetDate)),
+          .planEditPageResetTargetDateSubtitle(adjustedTargetDate)),
       trailing: Icon(Icons.arrow_forward),
       onTap: () {
         showDialog<String>(

lib/src/plans/presentations/plan_with_target_date_tile.dart

@@ -14,9 +14,6 @@ class PlanWithTargetDateTile extends ConsumerWidget {
     final plan = ref.watch(planEditProviderFamily(planId));
     ref.watch(planEditProviderFamily(planId));
     final planEdit = ref.read(planEditProviderFamily(planId).notifier);
-    final formattedTargetDate = plan.targetDate != null
-        ? MaterialLocalizations.of(context).formatCompactDate(plan.targetDate!)
-        : '';
     final planNotifier =
         planId != null ? ref.read(planProviderFamily(planId!).notifier) : null;
     final deviationDays = planNotifier?.getDeviationDays() ?? 0;
@@ -27,12 +24,12 @@ class PlanWithTargetDateTile extends ConsumerWidget {
         crossAxisAlignment: CrossAxisAlignment.start,
         children: <Widget>[
           Text(AppLocalizations.of(context).planEditPageWithTargetDateSubtitle),
-          if (planId != null && plan.withTargetDate)
+          if (planId != null && plan.withTargetDate && plan.targetDate != null)
             Text(
                 key: const Key('target-status'),
                 AppLocalizations.of(context)
                     .planEditPageWithTargetDateStatusSubtitle(
-                        formattedTargetDate,
+                        plan.targetDate!,
                         deviationDays > 0
                             ? 'ahead'
                             : deviationDays < 0