--repeat value should be a positive integer

nikophil · nikophil · commit e079b71ac6de · 2025-10-23T22:46:19.000+02:00
diff --git a/src/Framework/TestBuilder.php b/src/Framework/TestBuilder.php
@@ -36,6 +36,7 @@
      * @param ReflectionClass<TestCase> $theClass
      * @param non-empty-string          $methodName
      * @param list<non-empty-string>    $groups
+     * @param positive-int $repeat
      *
      * @throws InvalidDataProviderException
      */
@@ -86,6 +87,7 @@ public function build(ReflectionClass $theClass, string $methodName, array $grou
      * @param array<ProvidedData>                                                                                                                                               $data
      * @param array{backupGlobals: ?true, backupGlobalsExcludeList: list<string>, backupStaticProperties: ?true, backupStaticPropertiesExcludeList: array<string,list<string>>} $backupSettings
      * @param list<non-empty-string>                                                                                                                                            $groups
+     * @param positive-int $repeat
      */
     private function buildDataProviderTestSuite(string $methodName, string $className, array $data, bool $runTestInSeparateProcess, ?bool $preserveGlobalState, array $backupSettings, array $groups, int $repeat = 1): DataProviderTestSuite
     {
diff --git a/src/Framework/TestSuite.php b/src/Framework/TestSuite.php
@@ -96,6 +96,7 @@ public static function empty(string $name): static
     /**
      * @param ReflectionClass<TestCase> $class
      * @param list<non-empty-string>    $groups
+     * @param positive-int $repeat
      */
     public static function fromClassReflector(ReflectionClass $class, array $groups = [], int $repeat = 1): static
     {
@@ -145,6 +146,7 @@ final private function __construct(string $name)
      * Adds a test to the suite.
      *
      * @param list<non-empty-string> $groups
+     * @param positive-int $repeat
      */
     public function addTest(Test $test, array $groups = [], int $repeat = 1): void
     {
@@ -192,6 +194,7 @@ public function addTest(Test $test, array $groups = [], int $repeat = 1): void
      *
      * @param ReflectionClass<TestCase> $testClass
      * @param list<non-empty-string>    $groups
+     * @param positive-int $repeat
      *
      * @throws Exception
      */
@@ -228,6 +231,7 @@ public function addTestSuite(ReflectionClass $testClass, array $groups = [], int
      * leaving the current test run untouched.
      *
      * @param list<non-empty-string> $groups
+     * @param positive-int $repeat
      *
      * @throws Exception
      */
@@ -254,6 +258,7 @@ public function addTestFile(string $filename, array $groups = [], int $repeat =
      * Wrapper for addTestFile() that adds multiple test files.
      *
      * @param iterable<string> $fileNames
+     * @param positive-int $repeat
      *
      * @throws Exception
      */
@@ -508,6 +513,7 @@ public function isForTestClass(): bool
     /**
      * @param ReflectionClass<TestCase> $class
      * @param list<non-empty-string>    $groups
+     * @param positive-int $repeat
      *
      * @throws Exception
      */
diff --git a/src/TextUI/Configuration/Cli/Builder.php b/src/TextUI/Configuration/Cli/Builder.php
@@ -1214,7 +1214,13 @@ public function fromParameters(array $parameters): Configuration
                     break;
 
                 case '--repeat':
-                    $repeat = (int) $option[1]; // todo: superior to 1
+                    $repeat = (int) $option[1];
+
+                    if ($repeat < 1) {
+                        throw new Exception(
+                            'The value for the --repeat option must be a positive integer',
+                        );
+                    }
 
                     break;
 
diff --git a/src/TextUI/Configuration/Cli/Configuration.php b/src/TextUI/Configuration/Cli/Configuration.php
@@ -195,6 +195,7 @@
      * @param ?non-empty-list<non-empty-string>                    $testSuffixes
      * @param ?non-empty-list<non-empty-string>                    $coverageFilter
      * @param ?non-empty-list<non-empty-string>                    $extensions
+     * @param positive-int                                         $repeat
      */
     public function __construct(array $arguments, ?bool $all, ?string $atLeastVersion, ?bool $backupGlobals, ?bool $backupStaticProperties, ?bool $beStrictAboutChangesToGlobalState, ?string $bootstrap, ?string $cacheDirectory, ?bool $cacheResult, bool $checkPhpConfiguration, bool $checkVersion, ?string $colors, null|int|string $columns, ?string $configurationFile, ?string $coverageClover, ?string $coverageCobertura, ?string $coverageCrap4J, ?string $coverageHtml, ?string $coverageOpenClover, ?string $coveragePhp, ?string $coverageText, ?bool $coverageTextShowUncoveredFiles, ?bool $coverageTextShowOnlySummary, ?string $coverageXml, ?bool $pathCoverage, bool $warmCoverageCache, ?int $defaultTimeLimit, ?bool $disableCodeCoverageIgnore, ?bool $disallowTestOutput, ?bool $enforceTimeLimit, ?array $excludeGroups, ?int $executionOrder, ?int $executionOrderDefects, ?bool $failOnAllIssues, ?bool $failOnDeprecation, ?bool $failOnPhpunitDeprecation, ?bool $failOnPhpunitNotice, ?bool $failOnPhpunitWarning, ?bool $failOnEmptyTestSuite, ?bool $failOnIncomplete, ?bool $failOnNotice, ?bool $failOnRisky, ?bool $failOnSkipped, ?bool $failOnWarning, ?bool $doNotFailOnDeprecation, ?bool $doNotFailOnPhpunitDeprecation, ?bool $doNotFailOnPhpunitNotice, ?bool $doNotFailOnPhpunitWarning, ?bool $doNotFailOnEmptyTestSuite, ?bool $doNotFailOnIncomplete, ?bool $doNotFailOnNotice, ?bool $doNotFailOnRisky, ?bool $doNotFailOnSkipped, ?bool $doNotFailOnWarning, ?bool $stopOnDefect, ?bool $stopOnDeprecation, ?string $specificDeprecationToStopOn, ?bool $stopOnError, ?bool $stopOnFailure, ?bool $stopOnIncomplete, ?bool $stopOnNotice, ?bool $stopOnRisky, ?bool $stopOnSkipped, ?bool $stopOnWarning, ?string $filter, ?string $excludeFilter, ?string $generateBaseline, ?string $useBaseline, bool $ignoreBaseline, bool $generateConfiguration, bool $migrateConfiguration, ?array $groups, ?array $testsCovering, ?array $testsUsing, ?array $testsRequiringPhpExtension, bool $help, ?string $includePath, ?array $iniSettings, ?string $junitLogfile, ?string $otrLogfile, ?bool $includeGitInformation, bool $listGroups, bool $listSuites, bool $listTestFiles, bool $listTests, ?string $listTestsXml, ?bool $noCoverage, ?bool $noExtensions, ?bool $noOutput, ?bool $noProgress, ?bool $noResults, ?bool $noLogging, ?bool $processIsolation, ?int $randomOrderSeed, ?bool $reportUselessTests, ?bool $resolveDependencies, ?bool $reverseList, ?bool $stderr, ?bool $strictCoverage, ?string $teamcityLogfile, ?string $testdoxHtmlFile, ?string $testdoxTextFile, ?array $testSuffixes, ?string $testSuite, ?string $excludeTestSuite, bool $useDefaultConfiguration, ?bool $displayDetailsOnAllIssues, ?bool $displayDetailsOnIncompleteTests, ?bool $displayDetailsOnSkippedTests, ?bool $displayDetailsOnTestsThatTriggerDeprecations, ?bool $displayDetailsOnPhpunitDeprecations, ?bool $displayDetailsOnPhpunitNotices, ?bool $displayDetailsOnTestsThatTriggerErrors, ?bool $displayDetailsOnTestsThatTriggerNotices, ?bool $displayDetailsOnTestsThatTriggerWarnings, bool $version, ?array $coverageFilter, ?string $logEventsText, ?string $logEventsVerboseText, ?bool $printerTeamCity, ?bool $testdoxPrinter, ?bool $testdoxPrinterSummary, bool $debug, bool $withTelemetry, ?array $extensions, int $repeat)
     {
@@ -2580,6 +2581,9 @@ public function debug(): bool
         return $this->debug;
     }
 
+    /**
+     * @return positive-int
+     */
     public function repeat(): int
     {
         return $this->repeat;
diff --git a/src/TextUI/Configuration/Configuration.php b/src/TextUI/Configuration/Configuration.php
@@ -194,6 +194,9 @@
      */
     private ?string $generateBaseline;
     private bool $debug;
+    /**
+     * @var positive-int
+     */
     private int $repeat;
     private bool $withTelemetry;
 
@@ -215,6 +218,7 @@
      * @param non-empty-list<non-empty-string>                                            $testSuffixes
      * @param null|non-empty-string                                                       $generateBaseline
      * @param non-negative-int                                                            $shortenArraysForExportThreshold
+     * @param positive-int                                                                $repeat
      */
     public function __construct(array $cliArguments, ?string $configurationFile, ?string $bootstrap, array $bootstrapForTestSuite, bool $cacheResult, ?string $cacheDirectory, ?string $coverageCacheDirectory, Source $source, string $testResultCacheFile, ?string $coverageClover, ?string $coverageCobertura, ?string $coverageCrap4j, int $coverageCrap4jThreshold, ?string $coverageHtml, int $coverageHtmlLowUpperBound, int $coverageHtmlHighLowerBound, string $coverageHtmlColorSuccessLow, string $coverageHtmlColorSuccessMedium, string $coverageHtmlColorSuccessHigh, string $coverageHtmlColorWarning, string $coverageHtmlColorDanger, ?string $coverageHtmlCustomCssFile, ?string $coverageOpenClover, ?string $coveragePhp, ?string $coverageText, bool $coverageTextShowUncoveredFiles, bool $coverageTextShowOnlySummary, ?string $coverageXml, bool $pathCoverage, bool $ignoreDeprecatedCodeUnitsFromCodeCoverage, bool $disableCodeCoverageIgnore, bool $failOnAllIssues, bool $failOnDeprecation, bool $failOnPhpunitDeprecation, bool $failOnPhpunitNotice, bool $failOnPhpunitWarning, bool $failOnEmptyTestSuite, bool $failOnIncomplete, bool $failOnNotice, bool $failOnRisky, bool $failOnSkipped, bool $failOnWarning, bool $doNotFailOnDeprecation, bool $doNotFailOnPhpunitDeprecation, bool $doNotFailOnPhpunitNotice, bool $doNotFailOnPhpunitWarning, bool $doNotFailOnEmptyTestSuite, bool $doNotFailOnIncomplete, bool $doNotFailOnNotice, bool $doNotFailOnRisky, bool $doNotFailOnSkipped, bool $doNotFailOnWarning, bool $stopOnDefect, bool $stopOnDeprecation, ?string $specificDeprecationToStopOn, bool $stopOnError, bool $stopOnFailure, bool $stopOnIncomplete, bool $stopOnNotice, bool $stopOnRisky, bool $stopOnSkipped, bool $stopOnWarning, bool $outputToStandardErrorStream, int $columns, bool $noExtensions, ?string $pharExtensionDirectory, array $extensionBootstrappers, bool $backupGlobals, bool $backupStaticProperties, bool $beStrictAboutChangesToGlobalState, bool $colors, bool $processIsolation, bool $enforceTimeLimit, int $defaultTimeLimit, int $timeoutForSmallTests, int $timeoutForMediumTests, int $timeoutForLargeTests, bool $reportUselessTests, bool $strictCoverage, bool $disallowTestOutput, bool $displayDetailsOnAllIssues, bool $displayDetailsOnIncompleteTests, bool $displayDetailsOnSkippedTests, bool $displayDetailsOnTestsThatTriggerDeprecations, bool $displayDetailsOnPhpunitDeprecations, bool $displayDetailsOnPhpunitNotices, bool $displayDetailsOnTestsThatTriggerErrors, bool $displayDetailsOnTestsThatTriggerNotices, bool $displayDetailsOnTestsThatTriggerWarnings, bool $reverseDefectList, bool $requireCoverageMetadata, bool $noProgress, bool $noResults, bool $noOutput, int $executionOrder, int $executionOrderDefects, bool $resolveDependencies, ?string $logfileTeamcity, ?string $logfileJunit, ?string $logfileOtr, bool $includeGitInformationInOtrLogfile, ?string $logfileTestdoxHtml, ?string $logfileTestdoxText, ?string $logEventsText, ?string $logEventsVerboseText, bool $teamCityOutput, bool $testDoxOutput, bool $testDoxOutputSummary, ?array $testsCovering, ?array $testsUsing, ?array $testsRequiringPhpExtension, ?string $filter, ?string $excludeFilter, array $groups, array $excludeGroups, int $randomOrderSeed, bool $includeUncoveredFiles, TestSuiteCollection $testSuite, string $includeTestSuite, string $excludeTestSuite, ?string $defaultTestSuite, bool $ignoreTestSelectionInXmlConfiguration, array $testSuffixes, Php $php, bool $controlGarbageCollector, int $numberOfTestsBeforeGarbageCollection, ?string $generateBaseline, bool $debug, int $repeat, bool $withTelemetry, int $shortenArraysForExportThreshold)
     {
@@ -1516,6 +1520,9 @@ public function debug(): bool
         return $this->debug;
     }
 
+    /**
+     * @return positive-int
+     */
     public function repeat(): int
     {
         return $this->repeat;
diff --git a/src/TextUI/Configuration/TestSuiteBuilder.php b/src/TextUI/Configuration/TestSuiteBuilder.php
@@ -90,6 +90,7 @@ public function build(Configuration $configuration): TestSuite
     /**
      * @param non-empty-string       $path
      * @param list<non-empty-string> $suffixes
+     * @param positive-int $repeat
      *
      * @throws \PHPUnit\Framework\Exception
      */
@@ -137,6 +138,7 @@ private function testSuiteFromPath(string $path, array $suffixes, int $repeat, ?
     /**
      * @param list<non-empty-string> $paths
      * @param list<non-empty-string> $suffixes
+     * @param positive-int                                         $repeat
      *
      * @throws \PHPUnit\Framework\Exception
      */
diff --git a/tests/end-to-end/repeat/wonrg-repeat-value.phpt b/tests/end-to-end/repeat/wonrg-repeat-value.phpt
@@ -0,0 +1,17 @@
+--TEST--
+Repeat option
+--FILE--
+<?php declare(strict_types=1);
+$_SERVER['argv'][] = '--do-not-cache-result';
+$_SERVER['argv'][] = '--no-configuration';
+$_SERVER['argv'][] = '--repeat';
+$_SERVER['argv'][] = 'foo';
+$_SERVER['argv'][] = __DIR__ . '/_files/directory';
+
+require __DIR__ . '/../../bootstrap.php';
+
+(new PHPUnit\TextUI\Application)->run($_SERVER['argv']);
+--EXPECTF--
+PHPUnit %s by Sebastian Bergmann and contributors.
+
+The value for the --repeat option must be a positive integer

Original file line number	Diff line number	Diff line change
`@@ -96,6 +96,7 @@ public static function empty(string $name): static`
`96`	`96`	`/**`
`97`	`97`	`* @param ReflectionClass<TestCase> $class`
`98`	`98`	`* @param list<non-empty-string> $groups`
	`99`	`+ * @param positive-int $repeat`
`99`	`100`	`*/`
`100`	`101`	`public static function fromClassReflector(ReflectionClass $class, array $groups = [], int $repeat = 1): static`
`101`	`102`	`{`
`@@ -145,6 +146,7 @@ final private function __construct(string $name)`
`145`	`146`	`* Adds a test to the suite.`
`146`	`147`	`*`
`147`	`148`	`* @param list<non-empty-string> $groups`
	`149`	`+ * @param positive-int $repeat`
`148`	`150`	`*/`
`149`	`151`	`public function addTest(Test $test, array $groups = [], int $repeat = 1): void`
`150`	`152`	`{`
`@@ -192,6 +194,7 @@ public function addTest(Test $test, array $groups = [], int $repeat = 1): void`
`192`	`194`	`*`
`193`	`195`	`* @param ReflectionClass<TestCase> $testClass`
`194`	`196`	`* @param list<non-empty-string> $groups`
	`197`	`+ * @param positive-int $repeat`
`195`	`198`	`*`
`196`	`199`	`* @throws Exception`
`197`	`200`	`*/`
`@@ -228,6 +231,7 @@ public function addTestSuite(ReflectionClass $testClass, array $groups = [], int`
`228`	`231`	`* leaving the current test run untouched.`
`229`	`232`	`*`
`230`	`233`	`* @param list<non-empty-string> $groups`
	`234`	`+ * @param positive-int $repeat`
`231`	`235`	`*`
`232`	`236`	`* @throws Exception`
`233`	`237`	`*/`
`@@ -254,6 +258,7 @@ public function addTestFile(string $filename, array $groups = [], int $repeat =`
`254`	`258`	`* Wrapper for addTestFile() that adds multiple test files.`
`255`	`259`	`*`
`256`	`260`	`* @param iterable<string> $fileNames`
	`261`	`+ * @param positive-int $repeat`
`257`	`262`	`*`
`258`	`263`	`* @throws Exception`
`259`	`264`	`*/`
`@@ -508,6 +513,7 @@ public function isForTestClass(): bool`
`508`	`513`	`/**`
`509`	`514`	`* @param ReflectionClass<TestCase> $class`
`510`	`515`	`* @param list<non-empty-string> $groups`
	`516`	`+ * @param positive-int $repeat`
`511`	`517`	`*`
`512`	`518`	`* @throws Exception`
`513`	`519`	`*/`
Original file line number	Diff line number	Diff line change
`@@ -195,6 +195,7 @@`
`195`	`195`	`* @param ?non-empty-list<non-empty-string> $testSuffixes`
`196`	`196`	`* @param ?non-empty-list<non-empty-string> $coverageFilter`
`197`	`197`	`* @param ?non-empty-list<non-empty-string> $extensions`
	`198`	`+ * @param positive-int $repeat`
`198`	`199`	`*/`
`199`	`200`	public function __construct(array $arguments, ?bool $all, ?string $atLeastVersion, ?bool $backupGlobals, ?bool $backupStaticProperties, ?bool $beStrictAboutChangesToGlobalState, ?string $bootstrap, ?string $cacheDirectory, ?bool $cacheResult, bool $checkPhpConfiguration, bool $checkVersion, ?string $colors, null\|int\|string $columns, ?string $configurationFile, ?string $coverageClover, ?string $coverageCobertura, ?string $coverageCrap4J, ?string $coverageHtml, ?string $coverageOpenClover, ?string $coveragePhp, ?string $coverageText, ?bool $coverageTextShowUncoveredFiles, ?bool $coverageTextShowOnlySummary, ?string $coverageXml, ?bool $pathCoverage, bool $warmCoverageCache, ?int $defaultTimeLimit, ?bool $disableCodeCoverageIgnore, ?bool $disallowTestOutput, ?bool $enforceTimeLimit, ?array $excludeGroups, ?int $executionOrder, ?int $executionOrderDefects, ?bool $failOnAllIssues, ?bool $failOnDeprecation, ?bool $failOnPhpunitDeprecation, ?bool $failOnPhpunitNotice, ?bool $failOnPhpunitWarning, ?bool $failOnEmptyTestSuite, ?bool $failOnIncomplete, ?bool $failOnNotice, ?bool $failOnRisky, ?bool $failOnSkipped, ?bool $failOnWarning, ?bool $doNotFailOnDeprecation, ?bool $doNotFailOnPhpunitDeprecation, ?bool $doNotFailOnPhpunitNotice, ?bool $doNotFailOnPhpunitWarning, ?bool $doNotFailOnEmptyTestSuite, ?bool $doNotFailOnIncomplete, ?bool $doNotFailOnNotice, ?bool $doNotFailOnRisky, ?bool $doNotFailOnSkipped, ?bool $doNotFailOnWarning, ?bool $stopOnDefect, ?bool $stopOnDeprecation, ?string $specificDeprecationToStopOn, ?bool $stopOnError, ?bool $stopOnFailure, ?bool $stopOnIncomplete, ?bool $stopOnNotice, ?bool $stopOnRisky, ?bool $stopOnSkipped, ?bool $stopOnWarning, ?string $filter, ?string $excludeFilter, ?string $generateBaseline, ?string $useBaseline, bool $ignoreBaseline, bool $generateConfiguration, bool $migrateConfiguration, ?array $groups, ?array $testsCovering, ?array $testsUsing, ?array $testsRequiringPhpExtension, bool $help, ?string $includePath, ?array $iniSettings, ?string $junitLogfile, ?string $otrLogfile, ?bool $includeGitInformation, bool $listGroups, bool $listSuites, bool $listTestFiles, bool $listTests, ?string $listTestsXml, ?bool $noCoverage, ?bool $noExtensions, ?bool $noOutput, ?bool $noProgress, ?bool $noResults, ?bool $noLogging, ?bool $processIsolation, ?int $randomOrderSeed, ?bool $reportUselessTests, ?bool $resolveDependencies, ?bool $reverseList, ?bool $stderr, ?bool $strictCoverage, ?string $teamcityLogfile, ?string $testdoxHtmlFile, ?string $testdoxTextFile, ?array $testSuffixes, ?string $testSuite, ?string $excludeTestSuite, bool $useDefaultConfiguration, ?bool $displayDetailsOnAllIssues, ?bool $displayDetailsOnIncompleteTests, ?bool $displayDetailsOnSkippedTests, ?bool $displayDetailsOnTestsThatTriggerDeprecations, ?bool $displayDetailsOnPhpunitDeprecations, ?bool $displayDetailsOnPhpunitNotices, ?bool $displayDetailsOnTestsThatTriggerErrors, ?bool $displayDetailsOnTestsThatTriggerNotices, ?bool $displayDetailsOnTestsThatTriggerWarnings, bool $version, ?array $coverageFilter, ?string $logEventsText, ?string $logEventsVerboseText, ?bool $printerTeamCity, ?bool $testdoxPrinter, ?bool $testdoxPrinterSummary, bool $debug, bool $withTelemetry, ?array $extensions, int $repeat)
`200`	`201`	`{`
`@@ -2580,6 +2581,9 @@ public function debug(): bool`
`2580`	`2581`	`return $this->debug;`
`2581`	`2582`	`}`
`2582`	`2583`
	`2584`	`+ /**`
	`2585`	`+ * @return positive-int`
	`2586`	`+ */`
`2583`	`2587`	`public function repeat(): int`
`2584`	`2588`	`{`
`2585`	`2589`	`return $this->repeat;`