Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

【OSCP】[FNP04] 选择并在 SecretFlow 中实现多方 PSI 协议 #9 #16

Closed
wants to merge 4 commits into from
Closed

【OSCP】[FNP04] 选择并在 SecretFlow 中实现多方 PSI 协议 #9 #16

wants to merge 4 commits into from

Conversation

zhangwfjh
Copy link
Contributor

Fixed #9

zhanglei486
zhanglei486 approved these changes Dec 26, 2023
View reviewed changes
Copy link

@zhanglei486 zhanglei486 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

6fj
6fj requested changes Dec 26, 2023
View reviewed changes
bazel/repositories.bzl
@@ -58,6 +60,13 @@ def psi_deps():
remote = "{}/yacl.git".format(SECRETFLOW_GIT),
)

maybe(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

psi引入heu有点太重了，heu可以剥离paillier_zahlen 到yacl吗？

@usafchn

psi/psi/core/fnp04_mp_psi/BUILD.bazel Outdated Show resolved Hide resolved
psi/psi/psi.proto Outdated Show resolved Hide resolved
psi/psi/psi.proto Outdated Show resolved Hide resolved
psi/psi/operator/fnp04_mp_psi.cc Show resolved Hide resolved
psi/psi/core/fnp04_mp_psi/fnp04_mp_psi_test.cc Outdated Show resolved Hide resolved
@6fj
Copy link
Member

6fj commented Dec 26, 2023

Please also fix bazel linter issues.

@6fj
Copy link
Member

6fj commented Jan 9, 2024

Hi @zhangwfjh

We appreciate your contribution and code LGTM. However, at this moment we couldn't merge this PR since we are not going to import HEU into PSI.

This OSCP task will be marked as finished. Thank you!

@6fj 6fj closed this Jan 9, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jan 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@6fj 6fj 6fj requested changes

@zhanglei486 zhanglei486 zhanglei486 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FNP04]选择并在 SecretFlow 中实现多方 PSI 协议
3 participants
@zhangwfjh @6fj @zhanglei486