Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

在 SCQL 中实现单方算子 ceil #114

Closed
Candicepan opened this issue Jul 21, 2023 · 12 comments · Fixed by #133
Closed

在 SCQL 中实现单方算子 ceil #114

Candicepan opened this issue Jul 21, 2023 · 12 comments · Fixed by #133
Assignees
@cs1317
Labels
enhancement New feature or request OSCP SecretFlow Open Source Contribution Plan

Comments

@Candicepan
Copy link
Contributor

此 ISSUE 为 隐语开源共建计划（SecretFlow Open Source Contribution Plan，简称 SF OSCP）第二期任务 ISSUE，欢迎社区开发者参与共建～
若有感兴趣想要认领的任务，但还未报名，辛苦先完成报名进行哈～

任务介绍

  • 任务名称：在 SCQL 中实现单方算子 ceil
  • 技术方向：SCQL
  • 任务难度：进阶🌟🌟

详细要求

在 SCQL 中实现单方算子ceil，按照《SCQL 单方算子贡献指南》进行逐步贡献操作

能力要求

  • 熟悉 SQL 语法
  • 熟悉 Go 语言
  • 熟悉 SCQL 代码结构

操作说明
@Candicepan Candicepan converted this from a draft issue Jul 21, 2023
@Candicepan Candicepan added enhancement New feature or request OSCP SecretFlow Open Source Contribution Plan labels Jul 21, 2023
@cs1317
Copy link
Contributor

cs1317 commented Aug 7, 2023

cs1317 Give it to me

@YirongWho
Copy link
Contributor

YirongWho Give it to me

@Candicepan
Copy link
Contributor Author

YirongWho Give it to me

感谢你的认领哈～一位开发者在同一时间只能认领一个任务哈 可以先完成已经认领的任务哈～目前已经 #116 assign 给你啦～

@Candicepan
Copy link
Contributor Author

cs1317 Give it to me

感谢你的认领哈～一位开发者在同一时间只能认领一个任务哈 可以先完成已经认领的任务哈～目前已经 #113 assign 给你啦～ 可以在上一个任务提交 PR 后，对此类任务感兴趣再再次认领哈 再次感谢对隐语社区的支持呀

@cs1317
Copy link
Contributor

cs1317 commented Aug 9, 2023

cs1317 Give it to me

@cs1317
Copy link
Contributor

cs1317 commented Aug 9, 2023

下载scql源码

img_v2_0f345a43-60a7-4f70-9d6e-be867ba747fl_MIDDLE

@cs1317
Copy link
Contributor

cs1317 commented Aug 9, 2023

添加ceil测试用例

img_v2_bbab3cb9-142d-4b10-ab99-762cb6f5664l_MIDDLE

@cs1317
Copy link
Contributor

cs1317 commented Aug 9, 2023 •
edited
Loading

运行测试 go test ./pke/planner/core/...

img_v2_1ad86aa5-a64f-40c7-8839-2ecf64d55ffl_MIDDLE
报错：缺少ceil算子的相关实现

@cs1317
Copy link
Contributor

cs1317 commented Aug 9, 2023

在pkg/expression/expression_to_stmt.go中添加ceil算子

img_v2_82a467cc-9ea3-4b0d-a13f-389317c2625l_MIDDLE

@cs1317
Copy link
Contributor

cs1317 commented Aug 9, 2023

再次运行测试

img_v2_5920d0e9-ad3c-44cf-84c7-77963d81b4dl_MIDDLE

@Candicepan Candicepan moved this from Needs Triage to In Progress in OSCP Phase 2 Aug 9, 2023
This was referenced Aug 9, 2023
Closed
Closed
@Candicepan Candicepan moved this from In Progress to In Review in OSCP Phase 2 Aug 9, 2023
@cs1317 cs1317 mentioned this issue Aug 9, 2023
Merged
tongke6 pushed a commit that referenced this issue Aug 9, 2023
@cs1317
feat:add single party func ceil (#133)
dd76c6f 
在SCQL中实现单方算子ceil 
Fixed #114
@github-project-automation github-project-automation bot moved this from In Review to Done in OSCP Phase 2 Aug 9, 2023
@C4v1nc3mpT
Copy link

C4V1NC3MPT-196883 Give it to me

@Candicepan
Copy link
Contributor Author

C4V1NC3MPT-196883

hello～该任务已经被其他开发者完成并 close 了哈～可以认领其他感兴趣的任务呀 欢迎查看任务列表

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cs1317 cs1317

Labels
enhancement New feature or request OSCP SecretFlow Open Source Contribution Plan
Projects
No open projects
OSCP Phase 2
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat:add single party func ceil
feat:add single party func ceil
4 participants
@Candicepan @cs1317 @C4v1nc3mpT @YirongWho