[WIP][Workflow Interface]: Fix for FederatedRuntime with TLS (Issue #1265) #1327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ishant Thakare <ishantrog752@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Issue: #1265
Change Description & Modifications
agg_addrfield to use the Director's hostname and Synchronized the TLS configuration with the values provided byFederatedRuntimein thenetwork section of
plan.yamlfor alignment with the system configuration.plan.yamlare correctly propagated to the prepared workspace.Verfication
agg_addris correctly updated with the Director's hostname inplan.yaml, preventing recurrence of the issue.localhostand the machine's FQDN (e.gsoc-PF2F2E02.clients.intel.com)as the Common Name for the Director's certificates.
Files modified
openfl/experimental/workflow/federated/plan/plan.pyopenfl/experimental/workflow/runtime/federated_runtime.pyopenfl/experimental/workflow/workspace_export/export.pyNOTE
The Director Admin must ensure mTLS certificates have the correct Common Name (CN), matching the hostname in the Director's configuration. Envoy Admin and Experiment Manager must use this hostname to facilitate proper communication and prevent connectivity issues.
This PR fixes #1265