Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positive if parameter is zipped dictionary #398

Open
ericwb opened this issue Mar 31, 2024 · 0 comments
Open

False positive if parameter is zipped dictionary #398

ericwb opened this issue Mar 31, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@ericwb
Copy link
Contributor

ericwb commented Mar 31, 2024

Describe the bug
For some rules that check kwargs, if a zipped dict is passed as the argument, the rule fails to understand this.

For example:

SMTP(**smtp_kwargs)

To Reproduce
Steps to reproduce the behavior:

  1. Create an example where the argument is a zipped dict
  2. Run rule particular to that example

Expected behavior
Rules that check kwargs should not result in false positives or false negatives.

Version

precli 0.4.3.dev6
  python version = 3.12.1 (main, Dec 12 2023, 13:19:17) [Clang 15.0.0 (clang-1500.0.40.1)]

Additional context
https://github.com/apache/airflow/blob/main/airflow/providers/smtp/hooks/smtp.py#L135

@ericwb ericwb added the bug Something isn't working label Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant