Skip to content

Commit f7cc07b

Browse files
committed
Bugfixes in elber data_sample caused by coding convergence analysis for mmvt data_sample.
1 parent 1369eac commit f7cc07b

File tree

3 files changed

+24
-12
lines changed

3 files changed

+24
-12
lines changed

seekr2/continuous_integration/run_ci.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,9 +50,12 @@ def run_short_ci(model_input, cuda_device_index, long_check=True):
5050
return
5151

5252
def run_generic_hostguest_ci(cuda_device_index):
53+
#FF = "system"
54+
FF = "amber"
5355
with tempfile.TemporaryDirectory() as temp_dir:
5456
host_guest_model_input \
55-
= create_model_input.create_host_guest_mmvt_model_input(temp_dir)
57+
= create_model_input.create_host_guest_mmvt_model_input(
58+
temp_dir, ff=FF)
5659
host_guest_model_input.integrator_type = "langevin"
5760
host_guest_model_input.timestep = 0.004
5861
host_guest_model_input.hydrogenMass = 3.0

seekr2/modules/common_converge.py

Lines changed: 18 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@
2020
import seekr2.analyze as analyze
2121
import seekr2.modules.common_base as base
2222
import seekr2.modules.common_analyze as common_analyze
23+
import seekr2.modules.mmvt_analyze as mmvt_analyze
24+
import seekr2.modules.elber_analyze as elber_analyze
2325

2426
# The default number of points to include in convergence plots
2527
DEFAULT_NUM_POINTS = 100
@@ -163,17 +165,23 @@ def analyze_kinetics(model, analysis, max_step, k_on_state=None):
163165
k_on = 0.0
164166
k_off = analysis.k_off
165167
main_data_sample = analysis.main_data_sample
166-
if main_data_sample.pi_alpha is None:
167-
pi_alpha = None
168+
if isinstance(main_data_sample, mmvt_analyze.MMVT_data_sample):
169+
if main_data_sample.pi_alpha is None:
170+
pi_alpha = None
171+
else:
172+
pi_alpha = main_data_sample.pi_alpha.flatten()
173+
174+
return k_on, k_off, main_data_sample.N_alpha_beta, \
175+
array_to_dict(main_data_sample.T_alpha),\
176+
main_data_sample.k_alpha_beta, array_to_dict(pi_alpha), \
177+
collapse_list_of_dicts(main_data_sample.N_i_j_alpha), \
178+
collapse_list_of_dicts(main_data_sample.R_i_alpha), \
179+
main_data_sample.N_ij, main_data_sample.R_i
180+
168181
else:
169-
pi_alpha = main_data_sample.pi_alpha.flatten()
170-
171-
return k_on, k_off, main_data_sample.N_alpha_beta, \
172-
array_to_dict(main_data_sample.T_alpha),\
173-
main_data_sample.k_alpha_beta, array_to_dict(pi_alpha), \
174-
collapse_list_of_dicts(main_data_sample.N_i_j_alpha), \
175-
collapse_list_of_dicts(main_data_sample.R_i_alpha), \
176-
main_data_sample.N_ij, main_data_sample.R_i
182+
return k_on, k_off, {}, {}, {}, {}, {}, {}, main_data_sample.N_ij, \
183+
main_data_sample.R_i
184+
177185

178186
except (common_analyze.MissingStatisticsError, np.linalg.LinAlgError,
179187
AssertionError, ValueError) as e:

seekr2/tests/test_markov_chain_monte_carlo.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
"""
77

88
import numpy as np
9+
import pytest
910
import matplotlib.pyplot as plt
1011

1112
import seekr2.modules.common_base as base
@@ -144,6 +145,7 @@ def test_mcmc_algorithm_1_2x2_elber():
144145

145146
return
146147

148+
@pytest.mark.skip
147149
def test_mcmc_3x3_mmvt(tmpdir_factory):
148150
"""
149151
Use the same statistics to generate both MMVT and Elber rate matrices.
@@ -297,5 +299,4 @@ def test_mcmc_3x3_mmvt(tmpdir_factory):
297299
np.std(mmvt_q2_distribution), rtol=0.5, atol=0.01)
298300

299301
return
300-
301302

0 commit comments

Comments
 (0)