Skip to content

Commit ed8367d

Browse files
HumairAKsefgsefg
authored andcommitted
(fix): reduce executor logs (kubeflow#11169)
* remove driver logs from executor These logs congest the executor runtime logs making it difficult for the user to differentiate between logs. The driver logs are unnecessary here and can be removed to reduce this clutter. Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com> * remove duplicate emissary call in executor As per the initial inline dev comment, argo podspecpatch did not add the emissary call, and had to be manualy added. This was fixed a couple of argo versions back. However, as a result executor pod makes double calls to the executor, which as a consequence also results in superflous logs. This change removes the additional call to emissary to resolve this. Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com> --------- Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
1 parent d13eaaa commit ed8367d

File tree

2 files changed

+0
-4
lines changed

2 files changed

+0
-4
lines changed

backend/src/v2/component/launcher_v2.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,6 @@ func NewLauncherV2(ctx context.Context, executionID int64, executorInputJSON, co
8787
if err != nil {
8888
return nil, fmt.Errorf("failed to unmarshal executor input: %w", err)
8989
}
90-
glog.Infof("input ComponentSpec:%s\n", prettyPrint(componentSpecJSON))
9190
component := &pipelinespec.ComponentSpec{}
9291
err = protojson.Unmarshal([]byte(componentSpecJSON), component)
9392
if err != nil {

backend/src/v2/driver/driver.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -387,9 +387,6 @@ func initPodSpecPatch(
387387
userCmdArgs = append(userCmdArgs, container.Command...)
388388
userCmdArgs = append(userCmdArgs, container.Args...)
389389
launcherCmd := []string{
390-
// TODO(Bobgy): workaround argo emissary executor bug, after we upgrade to an argo version with the bug fix, we can remove the following line.
391-
// Reference: https://github.com/argoproj/argo-workflows/issues/7406
392-
"/var/run/argo/argoexec", "emissary", "--",
393390
component.KFPLauncherPath,
394391
// TODO(Bobgy): no need to pass pipeline_name and run_id, these info can be fetched via pipeline context and pipeline run context which have been created by root DAG driver.
395392
"--pipeline_name", pipelineName,

0 commit comments

Comments
 (0)