Skip to content

Commit 14868be

Browse files
committed
Fix lint errors
1 parent 1e0a564 commit 14868be

File tree

3 files changed

+11
-5
lines changed

3 files changed

+11
-5
lines changed

internal/provider/destination_subscription_resource.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -163,6 +163,7 @@ func (r *destinationSubscriptionResource) Create(ctx context.Context, req resour
163163
reverseETLSchedule, diags := getSchedule(ctx, plan.ReverseETLSchedule)
164164
if diags.HasError() {
165165
resp.Diagnostics.Append(diags...)
166+
166167
return
167168
}
168169

@@ -292,6 +293,7 @@ func (r *destinationSubscriptionResource) Update(ctx context.Context, req resour
292293
reverseETLSchedule, diags := getSchedule(ctx, plan.ReverseETLSchedule)
293294
if diags.HasError() {
294295
resp.Diagnostics.Append(diags...)
296+
295297
return
296298
}
297299

internal/provider/models/destination_subscription.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
package models
22

33
import (
4+
"fmt"
5+
46
"github.com/hashicorp/terraform-plugin-framework-jsontypes/jsontypes"
57
"github.com/hashicorp/terraform-plugin-framework/types"
68
"github.com/segmentio/public-api-sdk-go/api"
@@ -72,7 +74,7 @@ func getReverseETLSchedule(schedule *api.ReverseEtlScheduleDefinition) (*Reverse
7274
if schedule.Config.IsSet() {
7375
byteConfig, err := schedule.Config.MarshalJSON()
7476
if err != nil {
75-
return nil, err
77+
return nil, fmt.Errorf("failed to marshal reverse ETL schedule config: %w", err)
7678
}
7779
stringConfig := string(byteConfig)
7880

internal/provider/reverse_etl_model_resource.go

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -99,10 +99,12 @@ func (r *reverseETLModelResource) Create(ctx context.Context, req resource.Creat
9999
}
100100

101101
var scheduleConfig map[string]interface{}
102-
diags = plan.ScheduleConfig.Unmarshal(&scheduleConfig)
103-
resp.Diagnostics.Append(diags...)
104-
if resp.Diagnostics.HasError() {
105-
return
102+
if !plan.ScheduleConfig.IsNull() && !plan.ScheduleConfig.IsUnknown() {
103+
diags = plan.ScheduleConfig.Unmarshal(&scheduleConfig)
104+
resp.Diagnostics.Append(diags...)
105+
if resp.Diagnostics.HasError() {
106+
return
107+
}
106108
}
107109

108110
out, body, err := r.client.ReverseETLAPI.CreateReverseEtlModel(r.authContext).CreateReverseEtlModelInput(api.CreateReverseEtlModelInput{

0 commit comments

Comments
 (0)