Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Inclusion of special characters as accents in the letters for pashphrases #399

Open
brunohitman opened this issue May 28, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@brunohitman
Copy link

Inclusion of special characters as accents in the letters for pashphrases like [á,é,í,ó,ú,â,ê,î,ô,û...]

@brunohitman brunohitman added the enhancement New feature or request label May 28, 2024
@jdlcdl
Copy link
Collaborator

jdlcdl commented May 29, 2024

Just a thought on this:

  • when creating a new bip39 passphrase... device should be strict and only allow keys that are most common to most keyboards, else it could be difficult to recover on different devices/wallets.
  • when recovering an existing bip39 passphrase... device should be tolerant in allowing as many keyboards as might have been used to create the original wallet.

Not sure how best to achieve that on a stateless device, but would love to hear others' ideas on this.

I suspect that krux's "tools / create qrcode" might be useful, because maybe it could have many different keyboards, whereas "enter passphrase" is more limited, and the resulting qrcode with full utf support could be used to recover bip39 based wallets by scanning the self-created qrcode during the "scan passphrase" step of loading a wallet.

@tadeubas
Copy link
Contributor

tadeubas commented Jun 8, 2024

I've tested this with Sparrow, Seed Tool and Krux create a different fingerprint when scanning á as passphrase from QR code. This is a problem even if Krux can't type these special characters, both Sparrow and Seed Tool show 411905a1 for fingerprint, but Krux show 9325504a

@brunohitman
Copy link
Author

This is a big problem!

@odudex
Copy link
Member

odudex commented Jul 9, 2024

Incorporating a variety of language glyphs could compromise the user experience and pose risks; therefore, we currently have no plans to implement such a feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants