CURL return value not being interpreted correctly

[digitaldan]

on line 194 the httpRes is being set to the http response code, so like 200 on a success.

freeswitch-PushNotificator/mod_apn/mod_apn.c

Lines 194 to 200 in 999c394

	switch_curl_easy_getinfo(curl_handle, CURLINFO_RESPONSE_CODE, &httpRes);
	switch_curl_easy_cleanup(curl_handle);
	switch_curl_slist_free_all(headers);
	if (query != url_template) switch_safe_free(query);
	return httpRes;

but then on line 213 that gets treated as a CURL internal return code, where 0 is OK. So for me this always fails and while the message does post, mod_apn thinks that it did not and fails the call.

freeswitch-PushNotificator/mod_apn/mod_apn.c

Lines 213 to 218 in 999c394

	if (do_curl(event, profile) == CURLE_OK) {
	ret = SWITCH_TRUE;
	}
	return ret;
	}

I'm confused how this is working for anyone ? I have changed it so do_curl returns

return httpRes >= 200 && httpRes < 300;

and then check this with

if (do_curl(event, profile)) {
  ret = SWITCH_TRUE;
}

And this seems to work now, but i'm unclear how this was working before ?