Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch migration docs #1147

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

Patch migration docs #1147

wants to merge 7 commits into from

Conversation

philblackwood
Copy link
Contributor

closes #1140
closes #1142

Text added to describe manual steps needed.

@philblackwood philblackwood self-assigned this Aug 15, 2024
Copy link
Collaborator

@rjyounes rjyounes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made a couple of wording suggestions. You also need a release note.

@@ -8,7 +8,7 @@ the release package will include queries to facilitate the migration of existing

For changes that are not amenable to automatic migration, queries will be provided that
report the use of deleted or modified classes and properties so that mitigation measures
can be initiated.
can be initiated. For example, some may releases require manual intervention when a property is being replaced by its inverse (class expressions, restrictions, and definitions of subproperties).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
can be initiated. For example, some may releases require manual intervention when a property is being replaced by its inverse (class expressions, restrictions, and definitions of subproperties).
can be initiated. For example, some releases require manual intervention when a property is being replaced by its inverse (in class expressions, restrictions, and definitions of subproperties).

@@ -17,6 +17,12 @@ by the gist team to help migrate from the previous version of gist.
about changes that were made in gist and you will need to decide how you want
to handle the changes.

- **Manual updates for inverses:** Migration scripts do not update all class expressions in an ontology. In particular for gist 13, `owl:onProperty gist:hasPart` needs to be changed to `owl:onProperty [ owl:inverseOf gist:isPartOf ]`. Class expressions that include `gist:hasMember` need to be modified in a similar way. If you have created subproperties of `gist:hasPart` or `gist:hasMember` they will also need to be updated manually.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- **Manual updates for inverses:** Migration scripts do not update all class expressions in an ontology. In particular for gist 13, `owl:onProperty gist:hasPart` needs to be changed to `owl:onProperty [ owl:inverseOf gist:isPartOf ]`. Class expressions that include `gist:hasMember` need to be modified in a similar way. If you have created subproperties of `gist:hasPart` or `gist:hasMember` they will also need to be updated manually.
- **Manual updates for inverses:** Migration scripts do not update all class expressions in an ontology. In particular for gist 13, `owl:onProperty gist:hasPart` needs to be changed to `owl:onProperty [ owl:inverseOf gist:isPartOf ]`. Class expressions that include `gist:hasMember` or `gist:hasDirectPart` need to be modified in a similar way. If you have created subproperties of any of these properties, they will also need to be updated manually.

Copy link
Collaborator

@rjyounes rjyounes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with migration scripts and local files Correct migration scripts for inverse properties
2 participants